Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non informative log message in case of a non-existing user authentication #1593

Closed
orenbm opened this issue Jun 4, 2020 · 0 comments
Closed

Comments

@orenbm
Copy link
Member

orenbm commented Jun 4, 2020

Summary

In case a user sends an authn request with the authn authenticator,
and the user is not defined in Conjur, the log message will show:
Authentication Error: #<NoMethodError: undefined method valid_origin?' for nil:NilClass>`.

This is not informative and doesn't tell the user the real story. We should change
the message to:
Authentication Error: #<Errors::Authentication::Security::RoleNotFound: CONJ00007E ‘cucumber:user:non-existing-user’ not found>

Steps to Reproduce

Steps to reproduce the behavior:

  1. send an authn request with a user that doesn't exist
  2. Read the logs

Expected Results

An informative message is written: Authentication Error: #<Errors::Authentication::Security::RoleNotFound: CONJ00007E ‘cucumber:user:non-existing-user’ not found>

Actual Results (including error logs, if applicable)

message shows: Authentication Error: #<NoMethodError: undefined method `valid_origin?' for nil:NilClass>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant