-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config can be reloaded with conjurctl #2171
Comments
As it turns out, we can't currently use phased restart because we are preloading the application. From puma docs:
So we have to decide whether we want to:
This is what the docs say preloading does:
So in theory, if we remove preloading we will end up with additional memory usage in our puma process. |
After looking at memory usage in both scenarios, it doesn't look like the preload is actually saving us any memory. Both cluster workers appear to consume the same amount of memory with or without preload. with preload:
without preload:
|
It's worth noting that if we remove the preload, it does take a little bit longer for the main process to fork out the two workers. However, this is only a matter of a few seconds so it's fairly negligible. |
Add a
conjurctl configuration apply
command that validates configuration by instantiating aConjur::ConjurConfig
object. If validation fails, it should print the exception message to sderr and exit with code 1. If validation succeeds, it should restart the puma server using a phased restart using the following steps:ps -ef | grep puma | grep -v grep | grep -v cluster | awk '{print $2}' | tr -d '\n'
Process.kill('USR1', <pid>)
(see docs)Unit tests
Integration tests
conjur configuration apply
is run, Then the correct IP is displayed in an audit event based on the new configThe text was updated successfully, but these errors were encountered: