Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Connector Plugin #1026

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Adding Connector Plugin #1026

wants to merge 7 commits into from

Conversation

ralphieraccoon
Copy link
Contributor

Description
Integrating the Webots Connector node into webots_ros2.

Affected Packages

  • webots_ros2_driver
  • webots_ros2_msgs

@skpawar1305
Copy link
Contributor

I don't know anything about Webots Connector, please choose someone else as reviewer @ralphieraccoon

@ralphieraccoon ralphieraccoon requested review from angel-ayala and removed request for skpawar1305 January 20, 2025 10:52
@ralphieraccoon ralphieraccoon added the enhancement New feature or request label Jan 27, 2025
@angel-ayala angel-ayala requested a review from ygoumaz February 3, 2025 18:55
lukicdarkoo
lukicdarkoo requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@lukicdarkoo lukicdarkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ralphieraccoon Thank you, this looks quite good.

For wb_connector_lock() I would rather use a service, but this is fine too. We can add a service as well later.

Could you please add a test for this?

@ralphieraccoon
Copy link
Contributor Author

ralphieraccoon commented Feb 17, 2025 •
edited
Loading

No problem! I can write a service if you prefer, I used VacuumGripper as a template. I guess you might want a service for that too?

As for tests, is there a particular robot you'd like to use? I guess I could put a tool changer on a robot arm. Speaking of which, I think VacuumGripper is missing a test too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukicdarkoo lukicdarkoo lukicdarkoo requested changes

@angel-ayala angel-ayala Awaiting requested review from angel-ayala

@ygoumaz ygoumaz Awaiting requested review from ygoumaz

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralphieraccoon @skpawar1305 @lukicdarkoo