Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow runX as a workflow name #4394

Closed
MetRonnie opened this issue Sep 7, 2021 · 1 comment · Fixed by #4526
Closed

Disallow runX as a workflow name #4394

MetRonnie opened this issue Sep 7, 2021 · 1 comment · Fixed by #4526
Assignees
Labels
could be better Not exactly a bug, but not ideal. small
Milestone

Comments

@MetRonnie
Copy link
Member

MetRonnie commented Sep 7, 2021

As described by Bruno on Element, cylc install --flow-name=foo/run4 results in a run directory ~/cylc-run/foo/run4/run1 which is confusing, so should probably be disallowed. This should mean disallowing names matching the regex run\d+ (I think runN is already disallowed, but need to check that) and runN.

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@MetRonnie MetRonnie added small could be better Not exactly a bug, but not ideal. labels Sep 7, 2021
@MetRonnie MetRonnie added this to the cylc-8.x milestone Sep 7, 2021
@kinow
Copy link
Member

kinow commented Sep 13, 2021

(I think runN is already disallowed, but need to check that).

You are allowed to install a/b/c/runN. It creates the folders, but somewhere down the line Cylc Flow understands that is invalid and doesn't show it on cylc scan.

image

(venv) kinow@ranma:~/cylc-src/three$ cylc install --flow-name=a/b/c/runN
INSTALLED a/b/c/runN/run1 from /home/kinow/cylc-src/three
(venv) kinow@ranma:~/cylc-src/three$ cylc scan --state=all
five
747
three/run8
a/run1
a/b/run1
one/two/three/run2
one/two/three/run4 ranma:43010
one/two/three/run3 ranma:43023
one/two/three/run1 ranma:43085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal. small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants