Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow up 101 (task icons) #109

Closed
3 of 4 tasks
hjoliver opened this issue Jul 8, 2019 · 6 comments
Closed
3 of 4 tasks

follow up 101 (task icons) #109

hjoliver opened this issue Jul 8, 2019 · 6 comments
Labels

Comments

@hjoliver
Copy link
Member

hjoliver commented Jul 8, 2019

From bottom of description in #101

(We should either replace this issue with multiple separate issues, or turn the following into a
check-point list and address with multiple PRs)

TODO (future work)

  • Incorporate into views.
    • Work out how we are going to feed data into these components (e.g. props or whatever).
  • Animate state changes (see Task &/or job state transition monitoring #127)
    • Pure CSS probably wont be enough.
    • [edit] Actually CSS is probably the best bet, we are now using CSS animations to set the clock-face position.
    • More below...
  • Add the more eccentric task states (expired, queued, retrying) and the held badge.
    • Expired and queued are easy, the rest will require a dig into the Cylc Flow code to see what separation is possible with the current internals of Cylc.
  • (theme: job icons #134) Extract the <style> from the Job component to make it theme-able.
@hjoliver hjoliver mentioned this issue Jul 8, 2019
@kinow
Copy link
Member

kinow commented Jul 8, 2019

I think I can raise a PR for the first item about props.

@kinow
Copy link
Member

kinow commented Jul 9, 2019

I think I can raise a PR for the first item about props.

Done: #110

@oliver-sanders
Copy link
Member

Support for held and retrying states is blocked by:

@oliver-sanders oliver-sanders self-assigned this Jul 17, 2019
@kinow kinow added this to the 1.0 milestone Sep 14, 2019
@hjoliver
Copy link
Member Author

hjoliver commented Nov 9, 2019

Suggested icon design for expired task state (carried forward from #201):
image

@kinow kinow removed their assignment May 11, 2021
@kinow kinow modified the milestones: 1.0, 2.0 Sep 10, 2021
@oliver-sanders
Copy link
Member

The last thing on this issue is animation of state changes.

It might be useful to highlight state changes to make them more obvious to the user. IIn particular changes to the failed and submit-failed states.

Any animations would need to be minimal and subtle to avoid becoming more hindrance than help.

We are using CSS animations to set the clock-face position as the task is running. We have had to limit the number of frames for performance reasons so animations should be short lived and easy to compute too.

Suggest a quick, simple size or colour change.

@oliver-sanders oliver-sanders removed their assignment Feb 28, 2022
@oliver-sanders oliver-sanders modified the milestones: 2.0.0, Pending Jun 8, 2022
@oliver-sanders oliver-sanders removed this from the Pending milestone Oct 6, 2022
@oliver-sanders
Copy link
Member

The last point is covered by #127 so closing this umbrella issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants