Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update nyc reporter to lcov #34

Merged
merged 2 commits into from
Jul 11, 2019
Merged

fix: update nyc reporter to lcov #34

merged 2 commits into from
Jul 11, 2019

Conversation

fsmaia
Copy link
Contributor

@fsmaia fsmaia commented Jul 10, 2019

Fixes #33.

Tested locally and generate both HTML and LCOV reports, and it generated both reports to ./coverage/lcov-report.

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2019

CLA assistant check
All committers have signed the CLA.

@bahmutov
Copy link
Contributor

I checked it an it is true - it does save lcov and HTML reports into coverage folder - can you also update a README file, probably add a section there explaining the saved reports, please?

@fsmaia
Copy link
Contributor Author

fsmaia commented Jul 10, 2019

Done 😄

@bahmutov bahmutov merged commit 79d09a5 into cypress-io:master Jul 11, 2019
@bahmutov
Copy link
Contributor

super, thank you @fsmaia

@bahmutov
Copy link
Contributor

🎉 This PR is included in version 1.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jrnail23
Copy link

@fsmaia Thanks for this! This lets me get rid of my own workaround for this very issue! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Support lcov report
4 participants