-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch '10.0-release' into chore/apply-ux-feedback
- Loading branch information
Showing
12 changed files
with
247 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
181 changes: 181 additions & 0 deletions
181
packages/launchpad/cypress/e2e/integration/choose-a-browser.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,181 @@ | ||
| describe('Choose a Browser Page', () => { | ||
| // Walks through setup pages to get to browser selection | ||
| const stepThroughConfigPages = () => { | ||
| cy.get('h1').should('contain', 'Configuration Files') | ||
| cy.contains('button', 'Continue').click() | ||
| cy.get('h1').should('contain', 'Initializing Config...') | ||
| cy.contains('button', 'Next Step').click() | ||
| } | ||
|
|
||
| beforeEach(() => { | ||
| cy.scaffoldProject('launchpad') | ||
| }) | ||
|
|
||
| describe('System Browsers Detected', () => { | ||
| beforeEach(() => { | ||
| cy.findBrowsers({ | ||
| filter: (browser) => { | ||
| return Cypress._.includes(['chrome', 'firefox', 'electron', 'edge'], browser.name) && browser.channel === 'stable' | ||
| }, | ||
| }) | ||
| }) | ||
|
|
||
| it('preselects browser that is provided through the command line', () => { | ||
| cy.openProject('launchpad', ['--e2e', '--browser', 'edge']) | ||
|
|
||
| cy.visitLaunchpad() | ||
| stepThroughConfigPages() | ||
|
|
||
| cy.get('h1').should('contain', 'Choose a Browser') | ||
|
|
||
| cy.findByRole('radio', { name: 'Edge v8', checked: true }) | ||
| }) | ||
|
|
||
| it('shows warning when launched with --browser name that cannot be matched to found browsers', () => { | ||
| cy.openProject('launchpad', ['--e2e', '--browser', 'doesNotExist']) | ||
| cy.visitLaunchpad() | ||
|
|
||
| stepThroughConfigPages() | ||
|
|
||
| cy.get('h1').should('contain', 'Choose a Browser') | ||
| cy.get('[data-cy="alert-header"]').should('contain', 'Warning: Browser Not Found') | ||
| cy.get('[data-cy="alert-body"]') | ||
| .should('contain', 'The specified browser was not found on your system or is not supported by Cypress: doesNotExist') | ||
|
|
||
| cy.get('[data-cy="alert-body"] a').eq(1) | ||
| .should('have.attr', 'href') | ||
| .and('equal', 'https://on.cypress.io/troubleshooting-launching-browsers') | ||
|
|
||
| // Ensure warning can be dismissed | ||
| cy.get('[data-cy="alert-suffix-icon"]').click() | ||
| cy.get('[data-cy="alert-header"]').should('not.exist') | ||
| }) | ||
|
|
||
| it('shows warning when launched with --browser path option that cannot be matched to found browsers', () => { | ||
| cy.openProject('launchpad', ['--e2e', '--browser', '/path/does/not/exist']) | ||
|
|
||
| cy.visitLaunchpad() | ||
|
|
||
| stepThroughConfigPages() | ||
|
|
||
| cy.get('h1').should('contain', 'Choose a Browser') | ||
|
|
||
| cy.get('[data-cy="alert-header"]').should('contain', 'Warning: Browser Not Found') | ||
| cy.get('[data-cy="alert-body"]') | ||
| .should('contain', 'We could not identify a known browser at the path you specified: /path/does/not/exist') | ||
| .should('contain', 'spawn /path/does/not/exist ENOENT') | ||
|
|
||
| cy.get('[data-cy="alert-body"] a') | ||
| .should('have.attr', 'href') | ||
| .and('equal', 'https://on.cypress.io/troubleshooting-launching-browsers') | ||
|
|
||
| // Ensure warning can be dismissed | ||
| cy.get('[data-cy="alert-suffix-icon"]').click() | ||
| cy.get('[data-cy="alert-header"]').should('not.exist') | ||
| }) | ||
|
|
||
| it('shows installed browsers with their relevant properties', () => { | ||
| cy.openProject('launchpad', ['--e2e']) | ||
|
|
||
| cy.visitLaunchpad() | ||
|
|
||
| stepThroughConfigPages() | ||
|
|
||
| cy.get('h1').should('contain', 'Choose a Browser') | ||
|
|
||
| cy.findByRole('radio', { name: 'Chrome v1' }) | ||
|
|
||
| cy.findByRole('radio', { name: 'Firefox v5' }) | ||
|
|
||
| cy.findByRole('radio', { name: 'Electron v12' }) | ||
|
|
||
| cy.findByRole('radio', { name: 'Edge v8' }) | ||
| }) | ||
|
|
||
| it('performs mutation to launch selected browser when launch button is pressed', () => { | ||
| cy.openProject('launchpad', ['--e2e']) | ||
|
|
||
| cy.visitLaunchpad() | ||
|
|
||
| stepThroughConfigPages() | ||
|
|
||
| cy.get('h1').should('contain', 'Choose a Browser') | ||
|
|
||
| cy.contains('button', 'Launch Chrome').as('launchButton') | ||
|
|
||
| // Stub out response to prevent browser launch but not break internals | ||
| cy.intercept('mutation-OpenBrowser_LaunchProject', { | ||
| body: { | ||
| data: { | ||
| launchOpenProject: true, | ||
| setProjectPreferences: { | ||
| currentProject: { | ||
| id: 'test-id', | ||
| title: 'launchpad', | ||
| __typename: 'CurrentProject', | ||
| }, | ||
| __typename: 'Query', | ||
| }, | ||
| }, | ||
| }, | ||
| }).as('launchProject') | ||
|
|
||
| cy.get('@launchButton').click() | ||
|
|
||
| cy.wait('@launchProject').then(({ request }) => { | ||
| expect(request?.body.variables.browserPath).to.contain('/test/chrome/path') | ||
| expect(request?.body.variables.testingType).to.eq('e2e') | ||
| }) | ||
| }) | ||
|
|
||
| it('performs mutation to change selected browser when browser item is clicked', () => { | ||
| cy.openProject('launchpad', ['--e2e']) | ||
|
|
||
| cy.visitLaunchpad() | ||
| stepThroughConfigPages() | ||
|
|
||
| cy.get('h1').should('contain', 'Choose a Browser') | ||
|
|
||
| cy.findByRole('radio', { name: 'Chrome v1', checked: true }).as('chromeItem') | ||
| cy.findByRole('radio', { name: 'Firefox v5', checked: false }).as('firefoxItem') | ||
|
|
||
| cy.contains('button', 'Launch Chrome').should('be.visible') | ||
|
|
||
| cy.intercept('mutation-OpenBrowserList_SetBrowser').as('setBrowser') | ||
|
|
||
| cy.get('@firefoxItem').then(($input) => { | ||
| cy.get(`label[for=${$input.attr('id')}]`).click().then(() => { | ||
| cy.wait('@setBrowser').its('request.body.variables.id').should('eq', $input.attr('id')) | ||
| }) | ||
| }) | ||
|
|
||
| cy.findByRole('radio', { name: 'Chrome v1', checked: false }) | ||
| cy.findByRole('radio', { name: 'Firefox v5', checked: true }) | ||
|
|
||
| cy.contains('button', 'Launch Firefox').should('be.visible') | ||
| }) | ||
| }) | ||
|
|
||
| describe('No System Browsers Detected', () => { | ||
| it('shows single electron browser option when no system browsers are detected and process is running in electron', () => { | ||
| cy.log('This test simulates the Electron browser injection performed by server.getBrowsers') | ||
| cy.findBrowsers({ | ||
| filter: (browser) => { | ||
| return browser.name === 'electron' | ||
| }, | ||
| }) | ||
|
|
||
| cy.openProject('launchpad', ['--e2e']) | ||
|
|
||
| cy.visitLaunchpad() | ||
|
|
||
| stepThroughConfigPages() | ||
|
|
||
| cy.get('h1').should('contain', 'Choose a Browser') | ||
|
|
||
| cy.get('[data-cy="open-browser-list"]').children().should('have.length', 1) | ||
|
|
||
| cy.findByRole('radio', { name: 'Electron v12', checked: true }) | ||
| }) | ||
| }) | ||
| }) |
Oops, something went wrong.