From 50555f508ee6f27a9b70c054692afe0afdfd31dc Mon Sep 17 00:00:00 2001 From: Blue F Date: Mon, 25 Oct 2021 11:19:34 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Chris Breiding --- packages/data-context/test/unit/data-context.spec.ts | 4 ++-- .../driver/cypress/integration/commands/assertions_spec.js | 2 +- .../driver/cypress/integration/commands/navigation_spec.js | 2 +- packages/driver/cypress/integration/commands/request_spec.js | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/data-context/test/unit/data-context.spec.ts b/packages/data-context/test/unit/data-context.spec.ts index a48058590d38..3b9d0d9f16e9 100644 --- a/packages/data-context/test/unit/data-context.spec.ts +++ b/packages/data-context/test/unit/data-context.spec.ts @@ -19,14 +19,14 @@ const makeDataContext = (options) => { describe('@packages/data-context', () => { describe('initializeData', () => { - it('should initialize', async () => { + it('initializes', async () => { const context = makeDataContext() await context.initializeData() snapshot(context) }) - it('should skip first wizard step when given a testingType', async () => { + it('skips first wizard step when given a testingType', async () => { const context = makeDataContext({ launchArgs: { testingType: 'e2e', diff --git a/packages/driver/cypress/integration/commands/assertions_spec.js b/packages/driver/cypress/integration/commands/assertions_spec.js index 12312ba65ad8..1135fbb6c836 100644 --- a/packages/driver/cypress/integration/commands/assertions_spec.js +++ b/packages/driver/cypress/integration/commands/assertions_spec.js @@ -1,6 +1,6 @@ const { $, _ } = Cypress -describe('src/cy/commands/assertions', { retries: 2 }, () => { +describe('src/cy/commands/assertions', () => { before(() => { cy .visit('/fixtures/jquery.html') diff --git a/packages/driver/cypress/integration/commands/navigation_spec.js b/packages/driver/cypress/integration/commands/navigation_spec.js index f546a09faf6a..70656959d95c 100644 --- a/packages/driver/cypress/integration/commands/navigation_spec.js +++ b/packages/driver/cypress/integration/commands/navigation_spec.js @@ -4,7 +4,7 @@ const helpers = require('../../support/helpers') const { _, Promise, $ } = Cypress -describe('src/cy/commands/navigation', { retries: 2 }, () => { +describe('src/cy/commands/navigation', () => { context('#reload', () => { before(() => { cy diff --git a/packages/driver/cypress/integration/commands/request_spec.js b/packages/driver/cypress/integration/commands/request_spec.js index 9e7fa34f48ac..b466141e3613 100644 --- a/packages/driver/cypress/integration/commands/request_spec.js +++ b/packages/driver/cypress/integration/commands/request_spec.js @@ -3,7 +3,7 @@ const { _, Promise } = Cypress const RESPONSE_TIMEOUT = 22222 -describe('src/cy/commands/request', { retries: 2 }, () => { +describe('src/cy/commands/request', () => { context('#request', { responseTimeout: RESPONSE_TIMEOUT, }, () => {