fix(component-testing): ensure to call unmount after each test #15385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
elevatebart
approved these changes
Mar 10, 2021
|
You would not want to do this in a |
elevatebart
changed the title
elevatebart
reviewed
Mar 10, 2021
| @@ -52,15 +52,13 @@ export const AUT_IFRAME_MARGIN = { | |||
|
|
|||
| const App: React.FC<AppProps> = observer( | |||
| function App (props: AppProps) { | |||
| const searchRef = React.createRef<HTMLInputElement>(null) | |||
| const searchRef = React.useRef<HTMLInputElement>(null) | |||
There was a problem hiding this comment.
How are those changes related to this fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes cypress-io.atlassian.net/browse/CT-318
User facing changelog
N/A
Additional details
We need to unmount the previous node when using Vite or strange things happen. We do this in beforeEach.
How has the user experience changed?
It works properly now.
PR Tasks
N/A