Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component-testing): Increased timeout to allow useEffect to trigger #16091

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Apr 20, 2021

User facing changelog

N/A

Additional details

This will hopefully address the flake with @cypress/react tests on card-spec.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 20, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 20, 2021



Test summary

200 0 1 0Flakiness 0


Run details

Project cypress
Status Passed
Commit a34e6df
Started Apr 20, 2021 2:30 PM
Ended Apr 20, 2021 2:40 PM
Duration 10:27 💡
OS Linux Debian - 10.8
Browser Firefox 77

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😏

@agg23 agg23 merged commit 5fb5b41 into develop Apr 20, 2021
tgriesser added a commit that referenced this pull request Apr 21, 2021
…press into tgriesser/chore/improve-ci

* 'tgriesser/chore/improve-ci' of github.com:cypress-io/cypress:
  fix(deps): update dependency systeminformation to version 5.6.4 🌟 (#15819)
  docs: fix a typo of package name [skip ci] (#15783)
  chore: deduplicate yarn.lock (#15988)
  fix(webpack): allow load custom asset on windows (#16099)
  fix: Properly display unmount as a command (#16041)
  fix(component-testing): correct imports for relative paths in cypress.json  (#16056)
  Fixed missing SearchInput and improved SpecList scrolling (#16090)
  docs: update react docs (#16055)
  chore: Design System Cleanup (#16077)
  feat(component-testing): breaking: Add React rerender functionality (#16038)
  fix(component-testing): Increased timeout to allow  useEffect to trigger (#16091)
  chore: release @cypress/webpack-batteries-included-preprocessor-v2.2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants