fix: avoid unmounting React components twice #16280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
I tested it, working great - I could not get the invariant error. |
lmiller1990
previously approved these changes
Apr 30, 2021
elevatebart
dismissed stale reviews from ghost
and lmiller1990
The base branch was changed.
elevatebart
requested review from
jennifer-shehane and
kuceb
and removed request for
a team
elevatebart
force-pushed
the
fix/react-invariant-issue
branch
from
e14f4b4 to
cbdf9b8
Compare
lmiller1990
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
When clicking fast between specs we used to have a blocking error saying something about invariant,
After this PR the bug is gone.
Additional details
Unmounting was done twice and the second time was the culprit. If the two hooks are called quickly enough, the second one will try to change the invariant of the first and trigger this issue,
NOTE: I am 99% sure this is the only problem, but, since this cleanup was necessary anyway, this PR cannot hurt. If we notice the bug in the future, we can re-open the ticket.