Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(unify): removing prism and adding infrastructure for shiki #18514

Merged
merged 49 commits into from
Oct 19, 2021
Merged

feat(unify): removing prism and adding infrastructure for shiki #18514

merged 49 commits into from
Oct 19, 2021

Conversation

elevatebart
Copy link
Contributor

User facing changelog

Use shiki instead of prism to highlight code

Additional details

How has the user experience changed?

Screen Shot 2021-10-15 at 3 47 49 PM

Answers

  • It is easy enough to integrate
  • It fits our needs
  • The colors are set in JSON which might be a problem unless we generate the theme
  • Performance does not seem to be a problem neither does weight

@elevatebart elevatebart requested a review from a team as a code owner October 15, 2021 20:52
@elevatebart elevatebart requested review from BlueWinds and emilyrohrbough and removed request for a team October 15, 2021 20:52
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 15, 2021

Thanks for taking the time to open a PR!

@elevatebart elevatebart changed the base branch from develop to unified-desktop-gui October 15, 2021 20:52
@elevatebart elevatebart requested review from JessicaSachs and marktnoonan and removed request for BlueWinds and emilyrohrbough October 15, 2021 20:52
JessicaSachs
JessicaSachs suggested changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal changes

@JessicaSachs JessicaSachs changed the title Spike/use shiki feat(unify): removing prism and adding infrastructure for shiki Oct 15, 2021
JessicaSachs
JessicaSachs reviewed Oct 19, 2021
View reviewed changes
JessicaSachs and others added 18 commits October 19, 2021 03:12
@JessicaSachs
Update packages/frontend-shared/src/components/ShikiHighlight.vue
55958a7
@JessicaSachs
remove conflicting copy button
c607b47
@JessicaSachs
Merge branch 'spike/use-shiki' of https://github.com/cypress-io/cypress…
d50cc68 
… into spike/use-shiki
@lmiller1990
dont top level await
087debc
@elevatebart
add a readme for theme generation
452e7f6
@elevatebart
ignore generated theme
029fb48
@elevatebart
fix integration test in launchpad
d91d2c4
@elevatebart
fix other integration test
730be2b
Merge branch 'unified-desktop-gui' into spike/use-shiki
294f6ff
@elevatebart
bring back the cypress theme
871ca03
@JessicaSachs
fixing public path issue
b42c22b
@JessicaSachs
Merge branch 'spike/use-shiki' of https://github.com/cypress-io/cypress…
bbbb111 
… into spike/use-shiki
@elevatebart
make e2e work
6e54730
@elevatebart
fix yarn dev (remove the double slash)
55789ae
@elevatebart
review theme with ryan
8da29c1
@elevatebart
make copy on click optional
253693c
@elevatebart
adjust viewports
82188c1
@elevatebart
move generation of theme before vite build
25a521e
@lmiller1990 lmiller1990 merged commit 9a2e550 into unified-desktop-gui Oct 19, 2021
@lmiller1990 lmiller1990 deleted the spike/use-shiki branch October 19, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmiller1990 lmiller1990 lmiller1990 approved these changes

@marktnoonan marktnoonan Awaiting requested review from marktnoonan

@JessicaSachs JessicaSachs Awaiting requested review from JessicaSachs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elevatebart @JessicaSachs @lmiller1990