feat: use supportFile by testingType #19364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ FlakinessThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…jandro/feat/supportFile-by-testing-type
…jandro/feat/supportFile-by-testing-type
lmiller1990
previously approved these changes
Jan 4, 2022
.eslintignore
Outdated
| @@ -22,7 +22,8 @@ system-tests/projects/**/static/* | |||
| system-tests/projects/**/*.jsx | |||
| system-tests/projects/**/fail.js | |||
| system-tests/lib/scaffold/plugins/index.js | |||
| system-tests/lib/scaffold/support/index.js | |||
| system-tests/lib/scaffold/support/e2e.js | |||
| system-tests/lib/scaffold/support/commaponent.js | |||
There was a problem hiding this comment.
Is this supposed to be spelled commaponent.js?
…jandro/feat/supportFile-by-testing-type
|
I tried it out, seems great! I'll use your new error handling stuff for the
|
lmiller1990
previously approved these changes
Jan 5, 2022
tgriesser
reviewed
Jan 5, 2022
| const E2E_SCAFFOLD_BODY = (opts: E2eScaffoldOpts) => { | ||
| return ` | ||
| e2e: { | ||
| supportFile: ${opts.lang === 'ts' ? '\'cypress/support/e2e.ts\'' : '\'cypress/support/e2e.js\''}, |
There was a problem hiding this comment.
Suggested change
| supportFile: ${opts.lang === 'ts' ? '\'cypress/support/e2e.ts\'' : '\'cypress/support/e2e.js\''}, | |
| supportFile: '\'cypress/support/e2e.${opts.lang}\'', |
tgriesser
previously approved these changes
Jan 5, 2022
estrada9166
dismissed stale reviews from tgriesser and lmiller1990
via
fbea255
tgriesser
previously approved these changes
Jan 5, 2022
tgriesser
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?