Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check the port is avail on all local hosts #19402

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

elevatebart
Copy link
Contributor

If the port was taken by say a docker engine that did not respond to localhost but only to 127.0.0.1 vite-dev-server would still use that port and fail.

Once this fix is in, we check this port properly.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 16, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 16, 2021



Test summary

4248 0 47 0Flakiness 1


Run details

Project cypress
Status Passed
Commit f0253b2
Started Dec 16, 2021 4:29 PM
Ended Dec 16, 2021 4:38 PM
Duration 09:51 💡
OS Linux Debian - 10.10
Browser Chrome 96

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@elevatebart elevatebart merged commit 4826175 into master Dec 16, 2021
@elevatebart elevatebart deleted the elevatebart/fix/vite-dev-server-port branch December 16, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants