-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: supportFile path and supportFile false for vite on windows #21156
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment on readability.
122c0a4
to
34c87f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified vite-dev-server tests are passing on my Windows VM
User facing changelog
Fix supportFile error for applications using
vite-dev-server
for CT testing.Additional details
There were two issues with how we were handling the support file.
.replace
, causing the replaced value to becomeundefined
linkThis PR fixes both of them. I developed this PR on my Windows machine. All the tests for
@cypress/vite-dev-server
were failing for Windows but now they are passing. I also added additional test coverage for both webpack and vite dev-servers forsupportFile: false
.How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?