Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@cypress/vite-dev-server returns stubbed out vite plugin function when not in DEBUG and conflicts with vite-ssr plugin. #22021

Closed
JessicaSachs opened this issue Jun 1, 2022 · 3 comments · Fixed by #22055
Assignees
Labels
v10.0.0 🐛 Issue present since 10.0.0

Comments

@JessicaSachs
Copy link
Contributor

Current behavior

When trying to upgrade Vuetify (next branch) i’m running into an issue with the Vite Dev Server bundled in w Cy 10 — @cypress/vite-dev-server is adding a stub plugin when not in DBEUG mode, which doesn’t have a “name”. This name property is required.

image

Desired behavior

Not crash. Sanitize the array of plugins @cypress/vite-dev-server starts the vite dev server with.

Test code to reproduce

https://github.com/vuetifyjs/vuetify/tree/next

Cypress Version

10.0.0

Other

No response

@JessicaSachs JessicaSachs changed the title @cypress/vite-dev-server inspect plugin @cypress/vite-dev-server returns stubbed out vite plugin function and conflicts with vite-ssr plugin. Jun 1, 2022
@JessicaSachs JessicaSachs changed the title @cypress/vite-dev-server returns stubbed out vite plugin function and conflicts with vite-ssr plugin. @cypress/vite-dev-server returns stubbed out vite plugin function when not in DEBUG and conflicts with vite-ssr plugin. Jun 1, 2022
@baus baus added the PATCH label Jun 2, 2022
@rockhold rockhold added the v10.0.0 🐛 Issue present since 10.0.0 label Jun 2, 2022
@tgriesser
Copy link
Member

We should just be able to add a null filter on the plugins array:

plugins: [
      Cypress(config, vite),
      CypressInspect(config),
].filter(p => p != null)

@BlueWinds BlueWinds assigned ZachJW34 and unassigned BlueWinds Jun 2, 2022
@cypress-bot cypress-bot bot added the stage: investigating Someone from Cypress is looking into this label Jun 2, 2022
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: investigating Someone from Cypress is looking into this labels Jun 2, 2022
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jun 2, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 2, 2022

The code for this is done in cypress-io/cypress#22055, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 2, 2022

Released in 10.0.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.0.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 2, 2022
@mjhenkes mjhenkes removed the PATCH label Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
v10.0.0 🐛 Issue present since 10.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants