fix: remove dependency causing semantic-release to fail #23142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
ZachJW34
commented
Aug 5, 2022
| @@ -2,6 +2,7 @@ | |||
| "name": "@cypress/angular", | |||
| "version": "0.0.0-development", | |||
| "description": "Test Angular Components using Cypress", | |||
| "private": true, | |||
There was a problem hiding this comment.
Should have been marked as private since we haven't released yet 😅
admah
approved these changes
Aug 5, 2022
| @@ -2,6 +2,7 @@ | |||
| "name": "@cypress/angular", | |||
| "version": "0.0.0-development", | |||
| "description": "Test Angular Components using Cypress", | |||
| "private": true, | |||
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||||||||||||||||||
ZachJW34
changed the title
ZachJW34
changed the title
tbiethman
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
na
Additional details
Semantic release has been failing, possibly due to the semantic-release bump a few weeks ago. Hard to verify since we haven't had a passing
npm-releasejob in a while. The problem was due to peer-deps from the@cypress/code-coveragepackage innpm/vue. Removing this allowed thenpm-releasejob to move pass the error occurring in the@semantic-release/npm prepareplugin (I verified by sshing into the last masternpm-releasejob and runningyarn npm-release. The tokens were out of date so no packages were published).We weren't verifying the results of
code-coveragefor the vue cypress tests, and it makes more sense in a system test anyway. In fact, we aren't even running thenpm/vuecypress tests on CI right now. Going to follow up on this.Steps to test
No easy way to test this, since running
yarn npm-releaselocally is mostly stubbed. I had to ssh into circleci to verify the behavior.How has the user experience changed?
na
PR Tasks
cypress-documentation?type definitions?