fix: add v8 snapshot usage to cypress in cypress testing #24860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
ryanthemanuel
commented
Dec 6, 2022
ryanthemanuel
commented
Dec 6, 2022
| @@ -21,7 +21,7 @@ | |||
| "@babel/parser": "^7", | |||
| "@babel/plugin-syntax-typescript": "^7", | |||
| "@babel/plugin-transform-typescript": "^7", | |||
| "@babel/traverse": "^7", | |||
| "@babel/traverse": "7.15.4", | |||
There was a problem hiding this comment.
Updated this to match the rest of the repo.
ryanthemanuel
commented
Dec 6, 2022
AtofStryker
approved these changes
Dec 6, 2022
flotwig
reviewed
Dec 6, 2022
flotwig
approved these changes
Dec 6, 2022
lmiller1990
approved these changes
Dec 6, 2022
| @@ -310,6 +319,17 @@ export class ProjectConfigIpc extends EventEmitter { | |||
| debug(`no typescript found, just use regular Node.js`) | |||
| } | |||
|
|
|||
| if (process.env.CYPRESS_INTERNAL_E2E_TESTING_SELF_PARENT_PROJECT) { | |||
There was a problem hiding this comment.
Bit of a shame we need to ship test code to prod :'(
This is "the change" that lets v8 snapshots run in cy-in-cy?
There was a problem hiding this comment.
Is there anyway to verify it now uses snapshots in the tests? How do we know it works (and catch it if stops?)
There was a problem hiding this comment.
Yeah it's unfortunate, but I'm not sure of a clean way to do it otherwise with how everything is structured.
And, I like your idea. I added a check to ensure that we fail in cypress in cypress if the snapshot is unavailable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
n/a
Additional details
This adds support for utilizing the v8 snapshot in cypress in cypress testing. In order to do this, we need to ensure that when the child process is started it is done via the
spawncommand since electron has special logic in itsforkcommand which effectively disables the snapshot. This has the implication of having an additional Cypress icon in the dock on Macs, but that will only happen during development and is a small inconvenience given that we will be able to more accurately simulate prod during cypress in cypress tests.In addition, as just general cleanup, I cleaned up the
bytenodelogic and was able to make it a dev dependency by bundling it into the electron entry pointSteps to test
Running the app and launchpad tests is the best way to see this in action
How has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?