Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runnable:run:async only fires once for each hook #3744

Closed
kuceb opened this issue Mar 18, 2019 · 2 comments · Fixed by #3968 · May be fixed by Omrisnyk/npm-lockfiles#145 or Omrisnyk/npm-lockfiles#164
Closed

runnable:run:async only fires once for each hook #3744

kuceb opened this issue Mar 18, 2019 · 2 comments · Fixed by #3968 · May be fixed by Omrisnyk/npm-lockfiles#145 or Omrisnyk/npm-lockfiles#164
Assignees
@kuceb
Labels
type: bug

Comments

@kuceb
Copy link
Contributor

kuceb commented Mar 18, 2019 •
edited
Loading

runnable:run:async only fires once for each hook

this would cause screenshots to not be taken when:

  • test fails in afterEach/beforeEach hook after the hook has already passed
@kuceb kuceb self-assigned this Mar 18, 2019
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Mar 19, 2019
@jennifer-shehane jennifer-shehane mentioned this issue Mar 29, 2019
Closed
@kuceb kuceb mentioned this issue Apr 15, 2019
Merged
57 tasks
@kuceb kuceb changed the title runnable:run:async only fires once for each hooks runnable:run:async only fires once for each hook Oct 30, 2019
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Jun 16, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Jul 14, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Aug 10, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 10, 2020

The code for this is done in cypress-io/cypress#3968, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 20, 2020

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kuceb kuceb

Labels
type: bug
Projects
None yet
Milestone
No milestone
2 participants
@jennifer-shehane @kuceb