-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add typing for specType field on spec method #8256
fix: Add typing for specType field on spec method #8256
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NickBolles There are quite a few errors in our Type linter, could you take a look? https://circleci.com/gh/cypress-io/cypress/419610
@jennifer-shehane I just tried something, but I'm on my phone. If that doesn't work I'll check it out tomorrow on my computer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please fix the lint errors and add a JSDoc for the new type explaining those two types? With @see
links to our docs
@NickBolles Do you still have time to address the changes requested in this PR? We will have to close this PR due to inactivity otherwise. |
@jennifer-shehane That should take care of the linting issues. Thanks for the ping, let me know if there's anything else I need to do. |
Dismissing previous review as addressed
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Add typings for
specType
field onCypress.spec
Additional details
Typescript users will get a compilation error
How has the user experience changed?
PR Tasks
n/a
n/a
cypress-documentation
?n/a
type definitions
?cypress.schema.json
?n/a