Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove unused release plugins #900

Merged

Conversation

MikeMcC399
Copy link
Collaborator

This PR follows on from #722 (comment) which proposes to remove extra_plugins from the workflow. These plugins were inactive since the configuration was incomplete.

Changes

The following changes are made to .github/workflows/main.yml using the GitHub JavaScript action-for-semantic-release called by cycjimmy/semantic-release-action@v3:

  1. Remove the extra_plugins: parameter containing
          extra_plugins: |
            @semantic-release/git
            @semantic-release/changelog
  1. Change the branch parameter to branches. The branch parameter is only officially supported for semantic-release v16 and earlier. The workflow currently already uses v19.0.5 and there is no guarantee that future versions of the action will continue to provide an undocumented conversion of the old parameter name to the new parameter name.

Impact

The change should have no impact on the way that the release job of .github/workflows/main.yml carries out its work. This is simply a clean-up.

References

@MikeMcC399
Copy link
Collaborator Author

Due to its nature, this PR will only be tested when the next release takes place.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review May 4, 2023 06:29
@mschile mschile requested a review from ryanthemanuel May 4, 2023 21:47
@mschile mschile merged commit ad8e313 into cypress-io:master May 5, 2023
@MikeMcC399 MikeMcC399 deleted the refactor/release-extra-plugins branch May 5, 2023 14:41
@github-actions
Copy link

github-actions bot commented May 5, 2023

🎉 This PR is included in version 5.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants