Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda does not have the latest version #293

Closed
afonit opened this issue Dec 22, 2021 · 8 comments · Fixed by #295
Closed

Conda does not have the latest version #293

afonit opened this issue Dec 22, 2021 · 8 comments · Fixed by #295

Comments

@afonit
Copy link

afonit commented Dec 22, 2021

In the readme for installation I see it says:

mamba install -c conda-forge ipycytoscape

When I installed it I saw it was version 1.2.2 but on github I see 1.3.0 has been released.

Searching conda I found the package page:
https://anaconda.org/conda-forge/ipycytoscape

It looks like that is pointing to: https://github.com/QuantStack/ipycytoscape/

I see in the history there was a transfer of ownership to the cytoscape org.

I thought I would just point this discrepancy out since the readme shows conda-forge as a source for installation.

@ianhi
Copy link
Collaborator

ianhi commented Jan 4, 2022

Thanks for reporting!

The link is actually ok because it redirects (or maybe because it pulls from pypi?) but the build failed due to some dependency issues. going to release one soon that should fix

This was referenced Jan 4, 2022
@ianhi ianhi closed this as completed in #295 Jan 4, 2022
@ianhi
Copy link
Collaborator

ianhi commented Jan 4, 2022

making the release now

@ianhi
Copy link
Collaborator

ianhi commented Jan 4, 2022

sadly that did not fix it. there are other build issues :'( conda-forge/ipycytoscape-feedstock#21

@ianhi ianhi reopened this Jan 4, 2022
@marimeireles
Copy link
Collaborator

Super weird error.
Works on node 14, fails on 16, 17. I can kinda reproduce it locally but not sure what's causing it!
I asked a question in the conda-forge channel, in the meanwhile I'll try to fix it by sending another version bump... Let's see.
I'm thinking about just skipping v. 1.3.1 and 1.3.0 on conda-forge.

@ianhi
Copy link
Collaborator

ianhi commented Jan 17, 2022

for future me to not click through the error logs. The relevant error is:

  npm ERR! While resolving: [email protected]
  npm ERR! Found: [email protected]
  npm ERR! node_modules/karma
  npm ERR!   dev karma@"^3.0.0" from the root project
  npm ERR!
  npm ERR! Could not resolve dependency:
  npm ERR! peer karma@"1 || 2" from [email protected]
  npm ERR! node_modules/karma-typescript
  npm ERR!   dev karma-typescript@"^3.0.13" from the root project
  npm ERR!

@ianhi
Copy link
Collaborator

ianhi commented Jan 17, 2022

notably our karma-typescript (3.0.13) is pretty out of date - currently on 5.5.2

I wonder if updating that would solve the issue.

@marimeireles
Copy link
Collaborator

Yeah, the weird thing is that I tried locally and it worked for me.
But if I make X changes (idk which changes are) then, it doesn't work anymore.
I bumped the klarna versions and it's still working locally, just made a patch on conda-forge.

@marimeireles
Copy link
Collaborator

marimeireles commented Jan 18, 2022

So that appeased*! the gods of the CI. I'm leaving it like that, because it was working on my computer regardless!
I just made a patch. I'll add a PR to change the package.json here too.
Thanks @ianhi 🌸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants