Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for closest match while matching the urls for rule selection #661

Closed
3 tasks done
dadrus opened this issue Jun 3, 2023 · 0 comments · Fixed by #1358
Closed
3 tasks done

Add support for closest match while matching the urls for rule selection #661

dadrus opened this issue Jun 3, 2023 · 0 comments · Fixed by #1358
Labels
feature Used for new features
Milestone

Comments

@dadrus
Copy link
Owner

dadrus commented Jun 3, 2023

Preflight checklist

Describe the background of your feature request

As of today heimdall matches the urls of incoming requests either based on regular expressions or globs. While doing this it iterates over available rules in the order of their definition in the rule set. First match wins. While this approach is pretty simple and also straight forward in sense of rules definitions in a rule set - define the most specific rule first, it might be challenging to follow for bigger rule sets.

Describe your idea

The idea is to relax the above said rule so that there is no requirement to order rules in a rule set and let heilmdall calculate the Levenshtein distance instead for all matches and select the shortest for the given url and the match expressions in the matched rules.

That would simplify the rule set development - no need for a specific order any more if order matters

Are there any workarounds or alternatives?

Like written above, the rules must be ordered in the rule set with most specific at the top if the matching expressions in the defined rules would match same urls.

Version

v0.7.0-alpha

Additional Context

No response

@dadrus dadrus added the feature Used for new features label Jun 3, 2023
@dadrus dadrus added this to the Future milestone Jun 3, 2023
@dadrus dadrus modified the milestones: Future, v0.15.0-alpha Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Used for new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant