Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Critial Vulnerability for VirtualEnv - CVE-2024-53899 #26225

Closed
joshua-janicas opened this issue Dec 2, 2024 · 2 comments
Closed
Labels
area: python-dependencies Related to Python dependencies

Comments

@joshua-janicas
Copy link

What's the issue?

Hey all, I'm not sure if this is the right place for it for it but I'm trying to chase down a critical vulnerability flagged in our local DependencyTrack for any virtualenv version earlier than 20.26.6. https://nvd.nist.gov/vuln/detail/CVE-2024-53899. This issue was fixed via: pypa/virtualenv#2771.

I was taking a look into if Dagster was using virtualenv and I noticed that the version is a bit older https://github.com/dagster-io/dagster/blob/master/pyright/master/requirements-pinned.txt virtualenv==20.25.0

What did you expect to happen?

Update virtualenv references to address vulnerability.

How to reproduce?

No response

Dagster version

1.8.13, but currently exists up to (main) 1.9.3

Deployment type

Docker Compose

Deployment details

No response

Additional information

image

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.
By submitting this issue, you agree to follow Dagster's Code of Conduct.

@joshua-janicas joshua-janicas added the type: bug Something isn't working label Dec 2, 2024
@gibsondan
Copy link
Member

Hi @joshua-janicas - the dagster package doesn't have any dependencies on virtualenv. We'll look into updating the callsite you flagged, but that's only used by our type-checking / automated testing environment and shouldn't have any impact on users of the dagster package.

@gibsondan
Copy link
Member

Landed a change that increased that pin in our CI and testing (but it should not affect your usage of dagster as per above)

@garethbrickman garethbrickman added area: python-dependencies Related to Python dependencies and removed type: bug Something isn't working labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: python-dependencies Related to Python dependencies
Projects
None yet
Development

No branches or pull requests

3 participants