-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider more idomatic docker config #715
Comments
To be clear I'm happy to upstream only parts of this. I realize that the I think the If all or part of these changes would be welcome upstream I am happy to break apart the work |
Hey @chrishoage, thank you for the great suggestion! Yes, a PR for that would be much appreciated! :) |
Okay I will work on cleaning up my changes and upstream them. I will attempt to make everything backwards compatible as much as I can, but the move to (I'm a little busy a the moment so this may take until next week to complete) |
While working on my PR I made extensive changes to the Dockerfile and I'm wondering if you think I should upstream them.
entrypoint.sh
which configured the environmentdagu
to the docker group/config
. This is a more idiomatic way of handling docker container configsWhat this allows for is a much cleaner docker compose setup.
/entrypoint.d/*.sh
(this is not done in my test branch, but could very easily be added. I have a lazy ADDITIONAL_PACKAGES but I don't think this should be shipped as is)You can look at my changes here chrishoage@23eae41 and if any of these are worth upstreaming I can produce a PR with the parts you think would be a good fit for the official docker image.
The text was updated successfully, but these errors were encountered: