Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Set react and react-dom as peer dependencies #1

Open
joe-tohdjojo opened this issue Jan 4, 2019 · 1 comment
Open

Set react and react-dom as peer dependencies #1

joe-tohdjojo opened this issue Jan 4, 2019 · 1 comment

Comments

@joe-tohdjojo
Copy link
Contributor

In the package.json file, we are requiring react and react-dom as a dependency but this package shouldn't bring in it's own version of react if it's meant to be used with react and react-dom already. Those packages should be declared as peer dependencies. If I understand it correctly, this should reduce our bundle size as well since we wont be importing a separate version of react and react-dom

This fix should also fix the security vulnerability in react-dom mentioned here: https://nvd.nist.gov/vuln/detail/CVE-2018-6341

@Demven
Copy link
Contributor

Demven commented Jan 7, 2019

Great proposal, @joseph-tohdjojo I'll update it today!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants