Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create a load spinner for data fetching (WEB-100) #115

Open
dgarcia-appdev opened this issue Nov 3, 2024 · 7 comments
Open

chore: create a load spinner for data fetching (WEB-100) #115

dgarcia-appdev opened this issue Nov 3, 2024 · 7 comments
Labels

Comments

@dgarcia-appdev
Copy link
Contributor

Task

Create a load spinner that can be used when fetching data.

Steps to contribute. NEVER COMMIT TO MAIN. NEVER COMMIT TO MAIN. It should always be on your own branch and that branch name should match the issue. Ensure that you are addressing the correct issue. Each issue will be listed as something like a chore, fix, bug, etc. Your commit message MUST start with one of these tags that correspond with your issue. Followed by your commit message and your commit message must end with the branch name, for example (WEB-1)

An example commit message would look like this: chore: create contributing guidelines (WEB-8)

Commit messages should not be written in an action or present tense. It also should not mention tasks unrelated to the issue "Creating Contributing Guidelines and will work on next task" is not what we would want to see as a commit message.

After a pull request is approved, the branch should be deleted once merged.

@vazquezea96
Copy link

Hello team,
I'd like to work on this!

@dgarcia-appdev
Copy link
Contributor Author

@vazquezea96 are you still interested?

@vazquezea96
Copy link

Yes sir!

@dgarcia-appdev
Copy link
Contributor Author

@vazquezea96 alright go ahead and tackle it and create a PR for me to review. Let me know if you have any questions.

@dgarcia-appdev
Copy link
Contributor Author

This ticket is up for grabs

@pavittarx
Copy link
Contributor

pavittarx commented Jan 1, 2025

Clarifying question: the expectation is to add a loading spinner, that could be used at various places, when fetching data anywhere.

Also, are there existing places where this needs to be used?

@dgarcia-appdev
Copy link
Contributor Author

@pavittarx I believe you can find where the loader will be needed by searching "isLoading" in the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants