Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let ILayoutEngines perform custom actions #735

Closed
4 tasks done
dalyIsaac opened this issue Dec 22, 2023 · 0 comments · Fixed by #736
Closed
4 tasks done

Let ILayoutEngines perform custom actions #735

dalyIsaac opened this issue Dec 22, 2023 · 0 comments · Fixed by #736
Labels
core Whim enhancement New feature or request

Comments

@dalyIsaac
Copy link
Owner

dalyIsaac commented Dec 22, 2023 •
edited
Loading

With the move to immutable layout engines, layout engines can no longer perform actions and have them saved to the workspace.

Add PerformCustomAction so ILayoutEngine can perform custom actions, typically triggered by plugins.

This supports #634.

  • Add PerformCustomAction
  • Provide IWindow? as part of the argument
  • Tests
  • TODOs
@dalyIsaac dalyIsaac added core Whim enhancement New feature or request labels Dec 22, 2023
@dalyIsaac dalyIsaac added this to Whim Dec 22, 2023
@dalyIsaac dalyIsaac moved this to In Progress in Whim Dec 22, 2023
@dalyIsaac dalyIsaac linked a pull request Dec 22, 2023 that will close this issue
Let ILayoutEngines perform custom actions #736
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Whim Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Whim enhancement New feature or request
Projects
Whim
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Let ILayoutEngines perform custom actions dalyIsaac/Whim
1 participant
@dalyIsaac