Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate hop project from application #26

Open
pauloricardoferreira opened this issue Nov 26, 2022 · 1 comment
Open

Isolate hop project from application #26

pauloricardoferreira opened this issue Nov 26, 2022 · 1 comment

Comments

@pauloricardoferreira
Copy link

Hello.

Sorry for the English, I used google translator.

I would like to suggest a change to the xml.py file.

According to the documentation, it would be necessary to leave the hop artifacts in the home_home/project folder for the plugin to work correctly.

Analyzing the code I thought and tested the following solution.

the commented line is the original of the project and the line below is the change suggestion

#self.project_folder = f'{hop_home}/{project["projectHome"]}'

if hop_home == self.project_home:
self.project_folder = self.project_home
else:
self.project_folder = f'{hop_home}/{self.project_home}'

This way I can leave the hop project isolated from the hop application, gaining mobility.

for the documentation you could leave it like this:
If your project is in a custom location, in the apache airflow connection configuration, home_home must be the same as the folder where your project is, so the plugin works correctly.

Attention: it is necessary that the hop artifacts are in the Airflow container, in the same path.

code

hop

@pauloricardoferreira
Copy link
Author

Add PR #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant