Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the reason this project uses a different Spark version for testing? #18

Open
paulsasi opened this issue Nov 10, 2023 · 0 comments

Comments

@paulsasi
Copy link
Contributor

paulsasi commented Nov 10, 2023

Hi!

I've noticed the project's support for Spark 3.0.0, yet the build.sbt file employs Spark 2.4.5 for testing:

val sparkVersion = "3.0.0"
val sparkTestVersion = "2.4.5"
...
"com.holdenkarau" %% "spark-testing-base" % s"${sparkTestVersion}_0.14.0" % Test

I'm curious about the rationale behind this. Wouldn't it be more suitable to align the testing version with 3.0.0?

Attempting an upgrade, I found that there's no equivalent to com.holdenkarau.spark.testing.HDFSCluster in spark-testing-base version 1.X.X, a class heavily relied upon in our tests. (holdenk/spark-testing-base@09b031a)

Considering this, do you think it's worthwhile to invest effort in adapting the tests to accommodate Spark 3.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant