Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messageOnly option to welcomeDialog #66

Closed
ryanasik opened this issue May 26, 2023 · 14 comments
Closed

Add messageOnly option to welcomeDialog #66

ryanasik opened this issue May 26, 2023 · 14 comments
Assignees
Labels
enhancement New feature or request waiting feedback Waiting on feedback from requestor
Milestone

Comments

@ryanasik
Copy link

When opening the Help Dialog window, Configuration is blank as well as Connection, Download Mbps and Estimate (beta). This is still the same after Testing Connection completes.

@dan-snelson
Copy link
Collaborator

Thanks for reporting this, @ryanasik.

Please advise the settings you're using which reproduces the issue.

@dan-snelson dan-snelson self-assigned this May 26, 2023
@dan-snelson dan-snelson added the bug Something isn't working label May 26, 2023
@dan-snelson dan-snelson added this to the 1.11.1 milestone May 26, 2023
@ryanasik
Copy link
Author

I am only using the Catch all configuration.

@dan-snelson
Copy link
Collaborator

Sorry for any Dan-induced confusion …

… what are your settings for Lines 33 through 70 ?

@ryanasik
Copy link
Author

ryanasik commented May 26, 2023

# # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # #
# Script Version and Jamf Pro Script Parameters
# # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # #

scriptVersion="1.11.0"
export PATH=/usr/bin:/bin:/usr/sbin:/sbin
scriptLog="${4:-"/var/log/org.churchofjesuschrist.log"}"                        # Parameter 4: Script Log Location [ /var/log/org.churchofjesuschrist.log ] (i.e., Your organization's default location for client-side logs)
debugMode="${5:-"verbose"}"                                                     # Parameter 5: Debug Mode [ verbose (default) | true | false ]
welcomeDialog="${6:-"userInput"}"                                               # Parameter 6: Welcome dialog [ userInput (default) | video | false ]
completionActionOption="${7:-"Restart Attended"}"                               # Parameter 7: Completion Action [ wait | sleep (with seconds) | Shut Down | Shut Down Attended | Shut Down Confirm | Restart | Restart Attended (default) | Restart Confirm | Log Out | Log Out Attended | Log Out Confirm ]
requiredMinimumBuild="${8:-"disabled"}"                                         # Parameter 8: Required Minimum Build [ disabled (default) | 22E ] (i.e., Your organization's required minimum build of macOS to allow users to proceed; use "22E" for macOS 13.3)
outdatedOsAction="${9:-"/System/Library/CoreServices/Software Update.app"}"     # Parameter 9: Outdated OS Action [ /System/Library/CoreServices/Software Update.app (default) | jamfselfservice://content?entity=policy&id=117&action=view ] (i.e., Jamf Pro Self Service policy ID for operating system ugprades)
webhookURL="${10:-""}"                                                          # Parameter 10: Microsoft Teams or Slack Webhook URL [ Leave blank to disable (default) | https://microsoftTeams.webhook.com/URL | https://hooks.slack.com/services/URL ] Can be used to send a success or failure message to Microsoft Teams or Slack via Webhook. (Function will automatically detect if Webhook URL is for Slack or Teams; can be modified to include other communication tools that support functionality.)
presetConfiguration="${11:-""}"                                                 # Parameter 11: Specify a Configuration (i.e., `policyJSON`; NOTE: Only used when `welcomeDialog` is set to `video` or `false`)


# # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # #
# Various Feature Variables
# # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # #

debugModeSleepAmount="3"    # Delay for various actions when running in Debug Mode
failureDialog="true"        # Display the so-called "Failure" dialog (after the main SYM dialog) [ true | false ]



# # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # #
# Welcome Message User Input Customization Choices (thanks, @rougegoat!)
# # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # # #

# These control which user input boxes are added to the first page of Setup Your Mac. If you do not want to ask about a value, set it to any other value
promptForUsername="true"
prefillUsername="true"          # prefills the currently logged in user's username
promptForComputerName="true"
promptForAssetTag="true"
promptForRoom="true"
promptForBuilding="true"
promptForDepartment="true"
promptForConfiguration="true"   # Removes the Configuration dropdown entirely and uses the "Catch-all (i.e., used when `welcomeDialog` is set to `video` or `false`)" policyJSON

@dan-snelson
Copy link
Collaborator

@ryanasik:

Will you please reply with (or DM me on Slack) your entire customized SYM script?

With promptForConfiguration="true", you'll most likely observe the following:

Screenshot 2023-05-27 at 7 08 34 AM Screenshot 2023-05-27 at 7 08 49 AM

Sample SYM Script:

Setup-Your-Mac-via-Dialog-2023-05-27-070014.bash.zip

@dan-snelson dan-snelson added the waiting feedback Waiting on feedback from requestor label May 27, 2023
Copy link

I have the same issue when our Proxy Client is installed. When it is not installed the networkQuality command runs fine. So it might have to be related to that (whatever is running on your network). Maybe try a hotspot?

@dan-snelson dan-snelson added enhancement New feature or request and removed bug Something isn't working labels May 31, 2023
@dan-snelson dan-snelson changed the title Help dialog window issue Add messageOnly option to welcomeDialog May 31, 2023
@dan-snelson
Copy link
Collaborator

@ryanasik:

Thanks for sharing your use-case.

As mentioned via DM on the MacAdmins Slack, looks like …
welcomeDialog="${6:-"userInput"}" # Parameter 6: Welcome dialog [ userInput (default) | video | false ]

… needs to include an option for messageOnly so helpmessage will only include relevant information.

@dan-snelson dan-snelson modified the milestones: 1.11.1, 1.12.0 May 31, 2023
@dan-snelson dan-snelson removed the waiting feedback Waiting on feedback from requestor label May 31, 2023
@dan-snelson
Copy link
Collaborator

D-OH! I've overlooked this issue before committing 1.12.0-b9.

@dan-snelson
Copy link
Collaborator

@ryanasik: Please test-drive 1.12.0-b10.

@dan-snelson dan-snelson added the waiting feedback Waiting on feedback from requestor label Jul 8, 2023
@dan-snelson
Copy link
Collaborator

Addressed in Setup Your Mac 1.12.0.

@ryanasik
Copy link
Author

ryanasik commented Oct 3, 2023

@dan-snelson Confirmed this is working now when adding messageOnly in the Welcome Dialog (parameter 6). It might be good to update the Wiki to include messageOnly in the example text for others to know its available. Thank you for getting this added in!

@dan-snelson
Copy link
Collaborator

Thanks for confirming, @ryanasik.

See: D. Review the default Welcome dialog > Message Only

@ryanasik
Copy link
Author

ryanasik commented Oct 3, 2023

Ok thanks! I was referring to section G. Line 2

@dan-snelson
Copy link
Collaborator

Fixed! (Thanks for heads-up.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request waiting feedback Waiting on feedback from requestor
Projects
None yet
Development

No branches or pull requests

3 participants