Option to disable Banner Text #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a flag to hide the Banner Text. Handy if the Banner Image has text in it already.
|
I'm concerned with line 1502. |
|
The main thing this toggle addresses is situations where the branded banner already has text in it. In those situations, printing the Banner Text on top of the existing text in the image can make it extremely difficult to read. As for 1502 in particular, that title change only tells them that something has gone wrong. That information is also provided by the main body and the next screen. Normally it's fine to show, but if it's going to be hard to read anyway you may as well hide it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a flag to hide the Banner Text. Handy if the Banner Image has text in it already.