Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to embed video in either welcome dialog screen or setup screen #36

Closed
SirDrSpiderpig opened this issue Feb 2, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request testing needed On-hold, awaiting feedback waiting info On-hold, waiting information from requestor

Comments

@SirDrSpiderpig
Copy link

Since swiftdialog can do video based on url or local I think it would be nice to be able to embed a videos either at the welcome screen or the setup screen. Our onboarding takes a while and I think it would be cool to have a video playing welcoming them to the company and giving them advice how to set up their Mac.

Note: While all requests are welcome, finding available cycles to custom-code a feature we won't use in our production environment is always challenging.
Is feature request related to a problem? Please describe.
A clear, concise description of the problem. (i.e., I'm frustrated when ...)

Describe the solution you'd like
A clear, concise description of what you want to happen.

Describe alternatives you've considered
A clear, concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@SirDrSpiderpig SirDrSpiderpig added the enhancement New feature or request label Feb 2, 2023
@dan-snelson
Copy link
Owner

Thanks for the FR, @SirDrSpiderpig!

In the meantime, perhaps Introduction-to-Setup-Your-Mac.bash may prove helpful.

@SirDrSpiderpig
Copy link
Author

Thanks for the FR, @SirDrSpiderpig!

In the meantime, perhaps Introduction-to-Setup-Your-Mac.bash may prove helpful.

Looks good. Would you run this as the before script and then run the setup the Mac as the after?

@dan-snelson
Copy link
Owner

Yes; it's really just a proof-of-concept.

I'll take a squint at integrating it into SYM.

@dan-snelson
Copy link
Owner

@SirDrSpiderpig:

Please test-drive 1.8.0-rc1 with welcomeDialog="${6:-"video"}" for Line 37.

@dan-snelson dan-snelson added testing needed On-hold, awaiting feedback waiting info On-hold, waiting information from requestor labels Feb 28, 2023
@SirDrSpiderpig
Copy link
Author

Will try to test this week. Doing a training course so won’t be in the office much.

@dan-snelson
Copy link
Owner

Addressed in 1.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing needed On-hold, awaiting feedback waiting info On-hold, waiting information from requestor
Projects
None yet
Development

No branches or pull requests

2 participants