Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add namespaced and strict properties to store interfaces #272

Merged
merged 3 commits into from
Apr 29, 2022

Conversation

daniluk4000
Copy link
Contributor

@daniluk4000 daniluk4000 commented Mar 24, 2022

Add namespaced property to store interfaces to resolve types break in template

Closes #271

@vercel
Copy link

vercel bot commented Mar 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/danielroe/nuxt-typed-vuex/33GoNziApd1DoDm8Ce4KEsSt7EiP
✅ Preview: Failed

daniluk4000 added a commit to daniluk4000/nuxt-typed-vuex that referenced this pull request Mar 31, 2022
@vercel
Copy link

vercel bot commented Apr 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
typed-vuex ✅ Ready (Inspect) Visit Preview Apr 29, 2022 at 4:06PM (UTC)

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #272 (369d935) into main (c68d689) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          117       117           
  Branches        28        28           
=========================================
  Hits           117       117           
Impacted Files Coverage Δ
packages/typed-vuex/src/types/store.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c68d689...369d935. Read the comment docs.

@danielroe danielroe changed the title For #271: add namespaced property to store interfaces fix: add namespaced and strict properties to store interfaces Apr 29, 2022
@danielroe danielroe merged commit 0a5cf14 into danielroe:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: namespaced property breaks code completion for modules in template in Webstorm
2 participants