Soundfont.instrument with options.destination not taken into account

[dengarcia]

When we load an instrument using Soundfont.instrument with the options.destination set to a node a create (for example GainNode), it is not taken into account.

The doc tells us about the option destination which is not used:

Here what I changed in the code to make it work:

`function instrument (ac, name, options) {
if (arguments.length === 1) return function (n, o) { return instrument(ac, n, o) }
var opts = options || {}
var isUrl = opts.isSoundfontURL || isSoundfontURL
var toUrl = opts.nameToUrl || nameToUrl
var url = isUrl(name) ? name : toUrl(name, opts.soundfont, opts.format)

return load(ac, url, { only: opts.only || opts.notes }).then(function (buffers) {
var p = player(ac, buffers, opts).connect(opts.destination ? opts.destination : ac.destination)
p.url = url
p.name = name
return p
})
}
`

instead of this code
`function instrument (ac, name, options) {
if (arguments.length === 1) return function (n, o) { return instrument(ac, n, o) }
var opts = options || {}
var isUrl = opts.isSoundfontURL || isSoundfontURL
var toUrl = opts.nameToUrl || nameToUrl
var url = isUrl(name) ? name : toUrl(name, opts.soundfont, opts.format)

return load(ac, url, { only: opts.only || opts.notes }).then(function (buffers) {
var p = player(ac, buffers, opts).connect(ac.destination)
var p = player(ac, buffers, opts).connect(opts.destination ? opts.destination : ac.destination)
p.url = url
p.name = name
return p
})
}
`

[ryohey]

This seems to have been resolved in #57
@danigb Could you release new version?

[danigb]

Yes, is true. Sorry for not release. I'll do it ASAP

[danigb]

Done: published 0.10.7 👍

[ryohey]

@danigb Thank you so much!