Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset on synchronized graphs failed #524

Closed
ghplink opened this issue Dec 12, 2014 · 4 comments
Closed

Reset on synchronized graphs failed #524

ghplink opened this issue Dec 12, 2014 · 4 comments
Labels
Milestone

Comments

@ghplink
Copy link

ghplink commented Dec 12, 2014

In Synchronization example zoom y range in one graph by mouse drag. After that a double-click in another graph does not reset ranges. Even reset in first graph won't work anymore.
Defect is in version 1.1.0

@danvk danvk added the bug label Dec 12, 2014
@danvk
Copy link
Owner

danvk commented Dec 12, 2014

@danvk danvk added this to the 1.1.1 milestone Apr 12, 2015
@danvk
Copy link
Owner

danvk commented Apr 14, 2015

The core issue here is that resetZoom (which is called when you double-click on a chart to zoom out) doesn't reset the y-axis zoom when it's been set programmatically. It only resets the x-axis zoom. This doesn't make much sense, but it's a behavior that I'm reluctant to change for a point release. This may have to wait for 2.0.

@danvk danvk removed this from the 1.1.1 milestone Apr 20, 2015
@danvk
Copy link
Owner

danvk commented Apr 27, 2015

See #326

@danvk danvk added this to the 2.0.0 milestone Oct 24, 2015
@danvk
Copy link
Owner

danvk commented Dec 23, 2016

I think the right behavior is for double-clicking to be the same as calling resetZoom. And they should zoom out to the full range of the data on both axes.

The isZoomedIgnoreProgrammaticZoom option may be relevant here:

When this option is passed to updateOptions() along with either the dateWindow or valueRange options, the zoom flags are not changed to reflect a zoomed state. This is primarily useful for when the display area of a chart is changed programmatically and also where manual zooming is allowed and use is made of the isZoomed method to determine this.

See http://dygraphs.com/tests/is-zoomed-ignore-programmatic-zoom.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants