Treat etag errors across all state stores #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 30.57% 30.61% +0.04%
==========================================
Files 84 85 +1
Lines 7065 7107 +42
==========================================
+ Hits 2160 2176 +16
- Misses 4673 4697 +24
- Partials 232 234 +2
Continue to review full report at Codecov.
|
artursouza
approved these changes
Jan 9, 2021
rynowak
reviewed
Jan 9, 2021
| err := r.writeRow(req) | ||
| if req.ETag != "" { | ||
| return state.NewETagError(state.ETagMismatch, err) | ||
| } |
There was a problem hiding this comment.
@yaron2 - can you explain how this works? I'm not familiar with those code but it looks like this would return state.NewETagError every time an ETag is specified.
There was a problem hiding this comment.
Theres an err check missing here, I'll push a fix later
kumaya
pushed a commit
to infobloxopen/components-contrib
that referenced
this pull request
Feb 19, 2021
* treat etag errors across all state stores * linter * linter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates error handling for possible etag mismach and invalid etags across all state stores.
Partially closes dapr/dapr#2619