Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing error checks for etag errors #584

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Add missing error checks for etag errors #584

merged 1 commit into from
Jan 11, 2021

Conversation

yaron2
Copy link
Member

@yaron2 yaron2 commented Jan 11, 2021

This PR adds a few nil error checks for state stores. A follow up for #579

@yaron2 yaron2 requested a review from artursouza January 11, 2021 18:03
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #584 (3a76cf7) into master (4d3e1be) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
- Coverage   30.61%   30.61%   -0.01%     
==========================================
  Files          85       85              
  Lines        7107     7111       +4     
==========================================
+ Hits         2176     2177       +1     
- Misses       4697     4699       +2     
- Partials      234      235       +1     
Impacted Files Coverage Δ
state/aerospike/aerospike.go 19.29% <0.00%> (-0.35%) ⬇️
state/azure/tablestorage/tablestorage.go 14.43% <0.00%> (-0.31%) ⬇️
state/cloudstate/cloudstate_crdt.go 9.01% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d3e1be...4f6a47c. Read the comment docs.

@yaron2 yaron2 merged commit f44673c into dapr:master Jan 11, 2021
@yaron2 yaron2 deleted the etagerrfix-1 branch January 11, 2021 18:15
kumaya pushed a commit to infobloxopen/components-contrib that referenced this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants