Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindings need to document error codes for expected behaviors #1677

Closed
CodeMonkeyLeet opened this issue Jul 21, 2021 · 1 comment
Closed

Bindings need to document error codes for expected behaviors #1677

CodeMonkeyLeet opened this issue Jul 21, 2021 · 1 comment
Assignees
Labels
area/runtime/bindings content/missing-information More information requested or needed

Comments

@CodeMonkeyLeet
Copy link
Contributor

What content needs to be created or modified?

Quoting Talal from Discord:

How is response handled when it comes to errors? When I return a response with status code 404, I expect the binding to remove the message from the Queue. But that doesnt happen. Is there some documentation or any sample code I can refer from?

Sorry I was wrong. It is removing them from the queue. But it would still be good to have some documentation where it says for which error codes it removes, and for which it will retry

The question was asked in reference to Azure Service Bus Queues bindings, but applies more broadly to the bindings components. Particularly for bindings that are analogous to pubsub components (e.g. Event Hubs, Kafka), there's generally an expectation that similar error handling is available (e.g. SUCCESS, RETRY, DROP as in the PubSub API) This will probably need to be on a per component basis as the semantics are too specific for the generic Bindings API.

Describe the solution you'd like

For components that support additional error semantics such as Service Bus Queues, which seems to behave similarly to the Azure Service Bus pubsub component (404 causes message to be dropped, others will cause retry)

Where should the new material be placed?

Under the appropriate binding component spec.

@CodeMonkeyLeet CodeMonkeyLeet added the content/missing-information More information requested or needed label Jul 21, 2021
@hhunter-ms hhunter-ms self-assigned this Jul 13, 2023
@hhunter-ms
Copy link
Collaborator

will be addressed in #3907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime/bindings content/missing-information More information requested or needed
Projects
None yet
Development

No branches or pull requests

3 participants