Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete workflow methods #634

Closed
Tracked by #8008
famarting opened this issue Oct 10, 2024 · 4 comments
Closed
Tracked by #8008

Remove obsolete workflow methods #634

famarting opened this issue Oct 10, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@famarting
Copy link
Contributor

equivalent to dapr/dotnet-sdk#1344

the workflow methods defined here https://github.com/dapr/go-sdk/blob/main/client/workflow.go use a deprecated API and we aim to delete them

instead this client should be used https://github.com/dapr/go-sdk/blob/main/workflow/client.go and any docs should be updated to make use of it

@famarting
Copy link
Contributor Author

this issue can be closed since this has been merged #640

this issue does not consist of literally removing the workflow methods, but instead deprecating them and stop advising users to use them

@mikeee
Copy link
Member

mikeee commented Nov 20, 2024

IMO - idiomatic deprecation comments should be added to the relevant client methods before we bottom this issue out completely. e.g.

client/workflow.go

...
// StartWorkflowBeta1 starts a workflow using the beta1 spec.
// 
// Deprecated: Please use the workflow client (github.com/dapr/go-sdk/workflow).
// These methods of managing workflows are no longer supported and will be removed in the
// next release.
...

Wdyt @famarting?

@famarting
Copy link
Contributor Author

agree agree, will send a PR now adding these comments everywhere

@mikeee
Copy link
Member

mikeee commented Nov 20, 2024

Looks great, thanks for sorting this out 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants