-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usability enhancements for external package authors #64
Comments
Part of this is already covered in #58. What is still needed:
|
Note that it was not necessary #58 to move bit64 and bit32 (but you could still do it if it makes sense to you). |
This was referenced Apr 5, 2024
Closed
It might also make sense to implement some of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With PR #58 on its way it makes sense to think about how external users, in particular package authors, could make use of this:
dqrng::random_64bit_generator
which can be used together with C++ distribution functions since it supports UniformRandomBitGenerator. Note that in order to support the sampling methods this requires movingbit64()
andbit32()
fromrandom_64bit_wrapper
torandom_64bit_generator
as well as a change in the signature of these methods, i.e. the expected RNG should not come asdqrng::rng64_t
.dqRNGkind
. This can be handled by documenting best practices.dqrng::random_64bit_generator::clone(uint64_t stream)
. RNG specific implementations can be handled similarly to current stream specific template specializations. Note: I am not sure if one can implement this for the Threefry engine, as there is no way to increment the counter.The text was updated successfully, but these errors were encountered: