Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intergration into libp2p #1

Open
dariusc93 opened this issue Feb 11, 2023 · 0 comments
Open

Intergration into libp2p #1

dariusc93 opened this issue Feb 11, 2023 · 0 comments
Labels
question Further information is requested

Comments

@dariusc93
Copy link
Owner

This implementation relies 2 depenedencies igd-next and natpmp, with the latter being used as a fallback if igd fails. This behaviour works almost out of the box.

Currently, this solution may not be suitable to be apart of the libp2p transport itself as it relies on separate task with channels to communicate, as well as natpmp relies on FFI calls, which I believe rust-libp2p may not want to be apart of their codebase.

Thoughts for the future (may change over time):

  • Implement NATPMP (as well as PCP) in rust, with attempts not to rely on FFI calls to C code.
  • Simplify IGD as much as possible to reduce its dependency footprint (although it should be fine as is, but less dependencies is usually the better).

Reference:

@dariusc93 dariusc93 added the question Further information is requested label Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant