Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of integer division is confusing #4627

Closed
pbiggar opened this issue Dec 3, 2022 · 1 comment
Closed

Lack of integer division is confusing #4627

pbiggar opened this issue Dec 3, 2022 · 1 comment

Comments

@pbiggar
Copy link
Member

pbiggar commented Dec 3, 2022

In discord, @MatthiasPortzel asked about integer division. We do actually have integer division but he didn't notice it and used float division instead (with truncation, etc).

We used to have a warning in the error message, it was removed to speed along the migration. Instead, let's add it back in the editor. Possibly we want to give namesIDs or similar to error messages and then in the editor we can configure their display.

We also shouldn't have / be just a synonym for Float::divide - it should really be Float::divide in the AST with a "display" of /. This way, we could have / be a synonym for Int::divide as well.

@StachuDotNet
Copy link
Member

folded into #5239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants