Skip to content
This repository has been archived by the owner on Jan 17, 2024. It is now read-only.

Keep supporting Flutter 2 #170

Closed
martin-braun opened this issue Dec 22, 2022 · 4 comments
Closed

Keep supporting Flutter 2 #170

martin-braun opened this issue Dec 22, 2022 · 4 comments

Comments

@martin-braun
Copy link

Flutter 2 is not even one year old, but ffi 2.0.1 depends on SDK 2.17.0, which is Flutter 3. Can this be polyfilled to support SDK 2.16.2 (Flutter 2.10.5) for some more time please?

@dcharkes
Copy link
Contributor

We bumped to Dart 2.16 because we introduced uses of https://api.dart.dev/stable/2.18.6/dart-ffi/AbiSpecificInteger-class.html.

We subsequently decided to revert that.

Which reverted the Dart version back to 2.12.

Then we bumped to 2.17 in

Most likely due to the reference to https://api.dart.dev/stable/2.18.6/dart-ffi/NativeFinalizer-class.html in the docs, which was introduced in 2.17.

If it's only the docs reference we could possibly try to revert back to Dart 2.12 which is Flutter 2.0.0.

@dcharkes
Copy link
Contributor

In general, we'd like to be able to use new features introduces in Dart in this package.

See for example:

When we address this issue, we would bump to Dart 2.19.

@martin-braun what's your use case for staying at Flutter 2?

@dcharkes
Copy link
Contributor

@martin-braun could you try #171 with a dependency override as git dependency to see if it does what you need?

@martin-braun
Copy link
Author

@dcharkes Thank you for taking action so quick. Unfortunately, I had to decide to bump my plugin to Flutter 3 due to other non-related issues. I wish there was another way. I was requesting the backport, so that another plugin could start to work again, as my plugin is not depending on ffi, directly.

So in conclusion, it's not an issue anymore. For the future I hope that the Flutter team and Flutter plugin maintainers could try to give longer support times on legacy versions. Maybe an lts channel could be considered that plugin maintainers need to follow up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants