From 8c250575e7af92ef8131cc9b414e28bad5f7210e Mon Sep 17 00:00:00 2001 From: Nate Bosch Date: Fri, 16 Jun 2023 12:34:45 -0700 Subject: [PATCH] Unskip a skipped test (#966) The linked issue is closed as fixed. Skip only when required by the client implementation. --- .../http_client_conformance_tests/lib/src/redirect_tests.dart | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkgs/http_client_conformance_tests/lib/src/redirect_tests.dart b/pkgs/http_client_conformance_tests/lib/src/redirect_tests.dart index 6be306c787..6a5c547709 100644 --- a/pkgs/http_client_conformance_tests/lib/src/redirect_tests.dart +++ b/pkgs/http_client_conformance_tests/lib/src/redirect_tests.dart @@ -51,9 +51,7 @@ void testRedirect(Client client, {bool redirectAlwaysAllowed = false}) async { client.send(request), throwsA(isA() .having((e) => e.message, 'message', 'Redirect limit exceeded'))); - }, - skip: 'Re-enable after https://github.com/dart-lang/sdk/issues/49012 ' - 'is fixed'); + }, skip: redirectAlwaysAllowed ? 'redirects always allowed' : false); test('exactly the right number of allowed redirects', () async { final request = Request('GET', Uri.http(host, '/5'))