From c7dd3176592118c07b0c34463de854cd6d4b6749 Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Wed, 23 Oct 2024 14:52:07 -0700 Subject: [PATCH 01/11] Fix health --- .github/workflows/deart_health.yaml | 23 +++++++++++++++++++++++ .github/workflows/health.yaml | 14 -------------- 2 files changed, 23 insertions(+), 14 deletions(-) create mode 100644 .github/workflows/deart_health.yaml delete mode 100644 .github/workflows/health.yaml diff --git a/.github/workflows/deart_health.yaml b/.github/workflows/deart_health.yaml new file mode 100644 index 0000000000..5aba714dc2 --- /dev/null +++ b/.github/workflows/deart_health.yaml @@ -0,0 +1,23 @@ +name: Dart Health +on: + pull_request: + branches: [ master ] + types: [opened, synchronize, reopened, labeled, unlabeled] + paths: + - '.github/workflows/dart_health.yml' + - "pkgs/http/**" + - "pkgs/http_client_conformance_tests/**" + - "pkgs/http_parser/**" + - "pkgs/http_profile/**" + - "pkgs/http2/**" + - "pkgs/web_socket/**" + - "pkgs/web_socket_conformance_tests/**" + +jobs: + health: + uses: dart-lang/ecosystem/.github/workflows/health.yaml@main + with: + sdk: master + ignore_packages: "pkgs/cronet_http,pkgs/cupertino_http,pkgs/flutter_http_example,pkgs/java_http,pkgs/ok_http" + permissions: + pull-requests: write diff --git a/.github/workflows/health.yaml b/.github/workflows/health.yaml deleted file mode 100644 index 1c904405a2..0000000000 --- a/.github/workflows/health.yaml +++ /dev/null @@ -1,14 +0,0 @@ -name: Health -on: - pull_request: - branches: [ master ] - types: [opened, synchronize, reopened, labeled, unlabeled] - -jobs: - health: - uses: dart-lang/ecosystem/.github/workflows/health.yaml@main - with: - ignore_license: "**.g.dart" - sdk: dev - permissions: - pull-requests: write From 2f2de7f64f80cd96acf3362c57cd7eb7b0ab7337 Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Wed, 23 Oct 2024 14:59:04 -0700 Subject: [PATCH 02/11] Update deart_health.yaml --- .github/workflows/deart_health.yaml | 31 +++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/.github/workflows/deart_health.yaml b/.github/workflows/deart_health.yaml index 5aba714dc2..5728cf6a14 100644 --- a/.github/workflows/deart_health.yaml +++ b/.github/workflows/deart_health.yaml @@ -1,23 +1,34 @@ name: Dart Health on: + push: + branches: + - main + - master + paths: + - '.github/workflows/dart_health.yml' + - 'pkgs/http/**' + - 'pkgs/http_client_conformance_tests/**' + - 'pkgs/http_parser/**' + - 'pkgs/http_profile/**' + - 'pkgs/http2/**' + - 'pkgs/web_socket/**' + - 'pkgs/web_socket_conformance_tests/**' pull_request: - branches: [ master ] - types: [opened, synchronize, reopened, labeled, unlabeled] paths: - '.github/workflows/dart_health.yml' - - "pkgs/http/**" - - "pkgs/http_client_conformance_tests/**" - - "pkgs/http_parser/**" - - "pkgs/http_profile/**" - - "pkgs/http2/**" - - "pkgs/web_socket/**" - - "pkgs/web_socket_conformance_tests/**" + - 'pkgs/http/**' + - 'pkgs/http_client_conformance_tests/**' + - 'pkgs/http_parser/**' + - 'pkgs/http_profile/**' + - 'pkgs/http2/**' + - 'pkgs/web_socket/**' + - 'pkgs/web_socket_conformance_tests/**' jobs: health: uses: dart-lang/ecosystem/.github/workflows/health.yaml@main with: sdk: master - ignore_packages: "pkgs/cronet_http,pkgs/cupertino_http,pkgs/flutter_http_example,pkgs/java_http,pkgs/ok_http" + ignore_packages: 'pkgs/cronet_http,pkgs/cupertino_http,pkgs/flutter_http_example,pkgs/java_http,pkgs/ok_http' permissions: pull-requests: write From 74a291053151c51c167e64d3a8df052e574984b8 Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Wed, 23 Oct 2024 15:00:13 -0700 Subject: [PATCH 03/11] Update deart_health.yaml --- .github/workflows/deart_health.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deart_health.yaml b/.github/workflows/deart_health.yaml index 5728cf6a14..1a3e9fd79e 100644 --- a/.github/workflows/deart_health.yaml +++ b/.github/workflows/deart_health.yaml @@ -5,7 +5,7 @@ on: - main - master paths: - - '.github/workflows/dart_health.yml' + - '.github/workflows/dart_health.yaml' - 'pkgs/http/**' - 'pkgs/http_client_conformance_tests/**' - 'pkgs/http_parser/**' @@ -15,7 +15,7 @@ on: - 'pkgs/web_socket_conformance_tests/**' pull_request: paths: - - '.github/workflows/dart_health.yml' + - '.github/workflows/dart_health.yaml' - 'pkgs/http/**' - 'pkgs/http_client_conformance_tests/**' - 'pkgs/http_parser/**' From 7c6cb35850bbda8673e5d3078247efd6c2cac703 Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Wed, 23 Oct 2024 15:01:15 -0700 Subject: [PATCH 04/11] Rename --- .github/workflows/{deart_health.yaml => dart_health.yaml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{deart_health.yaml => dart_health.yaml} (100%) diff --git a/.github/workflows/deart_health.yaml b/.github/workflows/dart_health.yaml similarity index 100% rename from .github/workflows/deart_health.yaml rename to .github/workflows/dart_health.yaml From 8194345b2b6e7e577e9f05c5ad94ad8972b596b4 Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Wed, 23 Oct 2024 15:03:10 -0700 Subject: [PATCH 05/11] Update dart_health.yaml --- .github/workflows/dart_health.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/dart_health.yaml b/.github/workflows/dart_health.yaml index 1a3e9fd79e..a462e05617 100644 --- a/.github/workflows/dart_health.yaml +++ b/.github/workflows/dart_health.yaml @@ -28,7 +28,7 @@ jobs: health: uses: dart-lang/ecosystem/.github/workflows/health.yaml@main with: - sdk: master + sdk: stable ignore_packages: 'pkgs/cronet_http,pkgs/cupertino_http,pkgs/flutter_http_example,pkgs/java_http,pkgs/ok_http' permissions: pull-requests: write From a99bb666974a07fce75396b8f05dd65371f34538 Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Wed, 23 Oct 2024 15:13:33 -0700 Subject: [PATCH 06/11] Cupertino --- .github/workflows/cupertino.yml | 13 ++++++++++--- .github/workflows/dart_health.yaml | 1 + 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cupertino.yml b/.github/workflows/cupertino.yml index 68213aa069..24877a9e87 100644 --- a/.github/workflows/cupertino.yml +++ b/.github/workflows/cupertino.yml @@ -21,12 +21,15 @@ env: PUB_ENVIRONMENT: bot.github jobs: + health: + uses: dart-lang/ecosystem/.github/workflows/health.yaml@main + with: + use-flutter: true + fail_on: "changelog,license,coverage,breaking,do-not-submit,leaking" + sdk: stable verify: name: Format & Analyze & Test runs-on: macos-latest - defaults: - run: - working-directory: pkgs/cupertino_http strategy: fail-fast: false matrix: @@ -57,3 +60,7 @@ jobs: cd example flutter pub get flutter test integration_test/main.dart --test-randomize-ordering-seed=random + +defaults: + run: + working-directory: pkgs/cupertino_http diff --git a/.github/workflows/dart_health.yaml b/.github/workflows/dart_health.yaml index a462e05617..3bdb3862b3 100644 --- a/.github/workflows/dart_health.yaml +++ b/.github/workflows/dart_health.yaml @@ -29,6 +29,7 @@ jobs: uses: dart-lang/ecosystem/.github/workflows/health.yaml@main with: sdk: stable + fail_on: "changelog,license,coverage,breaking,do-not-submit,leaking" ignore_packages: 'pkgs/cronet_http,pkgs/cupertino_http,pkgs/flutter_http_example,pkgs/java_http,pkgs/ok_http' permissions: pull-requests: write From 7f5e9b1e758fa788f9a63bb3640e301d616366ab Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Wed, 23 Oct 2024 15:15:11 -0700 Subject: [PATCH 07/11] Warn --- .github/workflows/cupertino.yml | 1 + .github/workflows/dart_health.yaml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/cupertino.yml b/.github/workflows/cupertino.yml index 24877a9e87..706bc6656e 100644 --- a/.github/workflows/cupertino.yml +++ b/.github/workflows/cupertino.yml @@ -26,6 +26,7 @@ jobs: with: use-flutter: true fail_on: "changelog,license,coverage,breaking,do-not-submit,leaking" + warn_on: "" sdk: stable verify: name: Format & Analyze & Test diff --git a/.github/workflows/dart_health.yaml b/.github/workflows/dart_health.yaml index 3bdb3862b3..b506901466 100644 --- a/.github/workflows/dart_health.yaml +++ b/.github/workflows/dart_health.yaml @@ -30,6 +30,7 @@ jobs: with: sdk: stable fail_on: "changelog,license,coverage,breaking,do-not-submit,leaking" + warn_on: "" ignore_packages: 'pkgs/cronet_http,pkgs/cupertino_http,pkgs/flutter_http_example,pkgs/java_http,pkgs/ok_http' permissions: pull-requests: write From 60450686acb6d51c15964a2579bd17fe9181eebb Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Wed, 23 Oct 2024 15:16:53 -0700 Subject: [PATCH 08/11] Use defaults --- .github/workflows/cupertino.yml | 2 -- .github/workflows/dart_health.yaml | 2 -- 2 files changed, 4 deletions(-) diff --git a/.github/workflows/cupertino.yml b/.github/workflows/cupertino.yml index 706bc6656e..4423f6cbdb 100644 --- a/.github/workflows/cupertino.yml +++ b/.github/workflows/cupertino.yml @@ -25,8 +25,6 @@ jobs: uses: dart-lang/ecosystem/.github/workflows/health.yaml@main with: use-flutter: true - fail_on: "changelog,license,coverage,breaking,do-not-submit,leaking" - warn_on: "" sdk: stable verify: name: Format & Analyze & Test diff --git a/.github/workflows/dart_health.yaml b/.github/workflows/dart_health.yaml index b506901466..a462e05617 100644 --- a/.github/workflows/dart_health.yaml +++ b/.github/workflows/dart_health.yaml @@ -29,8 +29,6 @@ jobs: uses: dart-lang/ecosystem/.github/workflows/health.yaml@main with: sdk: stable - fail_on: "changelog,license,coverage,breaking,do-not-submit,leaking" - warn_on: "" ignore_packages: 'pkgs/cronet_http,pkgs/cupertino_http,pkgs/flutter_http_example,pkgs/java_http,pkgs/ok_http' permissions: pull-requests: write From 5874a147986c58541d59843cb2c4493d5cda0615 Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Wed, 23 Oct 2024 15:24:43 -0700 Subject: [PATCH 09/11] Update dart_health.yaml --- .github/workflows/dart_health.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/dart_health.yaml b/.github/workflows/dart_health.yaml index a462e05617..abcc92146f 100644 --- a/.github/workflows/dart_health.yaml +++ b/.github/workflows/dart_health.yaml @@ -30,5 +30,7 @@ jobs: with: sdk: stable ignore_packages: 'pkgs/cronet_http,pkgs/cupertino_http,pkgs/flutter_http_example,pkgs/java_http,pkgs/ok_http' + fail_on: "changelog,license,coverage,breaking,do-not-submit,leaking" + warn_on: "" permissions: pull-requests: write From 25cc118ae94a4ef9ff2bdb3eab652e4c5474630c Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Wed, 23 Oct 2024 15:33:23 -0700 Subject: [PATCH 10/11] Fixes --- .github/workflows/cronet.yml | 12 +++++++++--- .github/workflows/dart_health.yaml | 2 -- .github/workflows/okhttp.yaml | 12 +++++++++--- 3 files changed, 18 insertions(+), 8 deletions(-) diff --git a/.github/workflows/cronet.yml b/.github/workflows/cronet.yml index 9b2a4cfcf6..21c0969914 100644 --- a/.github/workflows/cronet.yml +++ b/.github/workflows/cronet.yml @@ -21,6 +21,11 @@ env: PUB_ENVIRONMENT: bot.github jobs: + health: + uses: dart-lang/ecosystem/.github/workflows/health.yaml@main + with: + use-flutter: true + sdk: stable verify: name: Format & Analyze & Test runs-on: ubuntu-latest @@ -29,9 +34,6 @@ jobs: fail-fast: false matrix: cronetHttpNoPlay: ['false', 'true'] - defaults: - run: - working-directory: pkgs/cronet_http steps: - name: Delete unnecessary tools 🔧 uses: jlumbroso/free-disk-space@v1.3.1 @@ -66,3 +68,7 @@ jobs: arch: x86_64 target: ${{ matrix.cronetHttpNoPlay == 'true' && 'default' || 'google_apis' }} script: cd pkgs/cronet_http/example && flutter test --dart-define=cronetHttpNoPlay=${{ matrix.cronetHttpNoPlay }} --timeout=1200s integration_test/ + +defaults: + run: + working-directory: pkgs/cronet_http \ No newline at end of file diff --git a/.github/workflows/dart_health.yaml b/.github/workflows/dart_health.yaml index abcc92146f..a462e05617 100644 --- a/.github/workflows/dart_health.yaml +++ b/.github/workflows/dart_health.yaml @@ -30,7 +30,5 @@ jobs: with: sdk: stable ignore_packages: 'pkgs/cronet_http,pkgs/cupertino_http,pkgs/flutter_http_example,pkgs/java_http,pkgs/ok_http' - fail_on: "changelog,license,coverage,breaking,do-not-submit,leaking" - warn_on: "" permissions: pull-requests: write diff --git a/.github/workflows/okhttp.yaml b/.github/workflows/okhttp.yaml index 367bcf2732..c6f7e4188f 100644 --- a/.github/workflows/okhttp.yaml +++ b/.github/workflows/okhttp.yaml @@ -21,12 +21,14 @@ env: PUB_ENVIRONMENT: bot.github jobs: + health: + uses: dart-lang/ecosystem/.github/workflows/health.yaml@main + with: + use-flutter: true + sdk: stable verify: name: Format & Analyze & Test runs-on: ubuntu-latest - defaults: - run: - working-directory: pkgs/ok_http steps: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 - uses: actions/setup-java@99b8673ff64fbf99d8d325f52d9a5bdedb8483e9 @@ -56,3 +58,7 @@ jobs: api-level: 21 arch: x86_64 script: cd pkgs/ok_http/example && flutter test --timeout=1200s integration_test/ + +defaults: + run: + working-directory: pkgs/ok_http \ No newline at end of file From 2f22ce92aba24daa12bbd688b60b146b251763fe Mon Sep 17 00:00:00 2001 From: Brian Quinlan Date: Wed, 23 Oct 2024 16:38:57 -0700 Subject: [PATCH 11/11] Checks --- .github/workflows/cronet.yml | 2 +- .github/workflows/cupertino.yml | 2 +- .github/workflows/dart_health.yaml | 2 +- .github/workflows/okhttp.yaml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cronet.yml b/.github/workflows/cronet.yml index 21c0969914..440cd93ed4 100644 --- a/.github/workflows/cronet.yml +++ b/.github/workflows/cronet.yml @@ -71,4 +71,4 @@ jobs: defaults: run: - working-directory: pkgs/cronet_http \ No newline at end of file + working-directory: pkgs/cronet_http diff --git a/.github/workflows/cupertino.yml b/.github/workflows/cupertino.yml index 4423f6cbdb..8df6e1af58 100644 --- a/.github/workflows/cupertino.yml +++ b/.github/workflows/cupertino.yml @@ -62,4 +62,4 @@ jobs: defaults: run: - working-directory: pkgs/cupertino_http + working-directory: pkgs/cupertino_http diff --git a/.github/workflows/dart_health.yaml b/.github/workflows/dart_health.yaml index a462e05617..fc589f7c2e 100644 --- a/.github/workflows/dart_health.yaml +++ b/.github/workflows/dart_health.yaml @@ -1,4 +1,4 @@ -name: Dart Health +name: Dart Packages Health on: push: branches: diff --git a/.github/workflows/okhttp.yaml b/.github/workflows/okhttp.yaml index c6f7e4188f..45734aca26 100644 --- a/.github/workflows/okhttp.yaml +++ b/.github/workflows/okhttp.yaml @@ -61,4 +61,4 @@ jobs: defaults: run: - working-directory: pkgs/ok_http \ No newline at end of file + working-directory: pkgs/ok_http