-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static Metaprogramming #1482
Comments
Would static function composition be in the scope of this feature? At the moment, higher-order functions in Dart are fairly limited since they require knowing the full prototype of the decorated function. An example would be a void Function() debouce(Duration duration, void Function() decorated) {
Timer? timer;
return () {
timer?.cancel();
timer = Timer(duration, () => decorated());
};
} which allows us to, instead of: class Example {
void doSomething() {
}
} write: class Example {
final doSomething = debounce(Duration(seconds: 1), () {
});
} but that comes with a few drawbacks:
With static meta-programming, our class Example {
@Debounce(Duration(seconds: 1))
void doSomething() {
print('doSomething');
}
@Debounce(Duration(seconds: 1))
void doSomethingElse(int value, {String named}) {
print('doSomethingElse $value named: $named');
}
} |
There is a delicate balance re: static function composition, but there are certainly many useful things that could be done with it. I think ultimately it is something we would like to support as long as we can make it obvious enough that this wrapping is happening. The specific balance would be around user confusion - we have a guiding principle that we don't want to allow overwriting of code in order to ensure that programs keep their original meaning. There are a lot of useful things you could do by simply wrapping a function in some other function (some additional ones might include uniform exception handling, analytics reporting, argument validation, etc). Most of these things would not change the meaning really of the original function, but the code is being "changed" in some sense by being wrapped. Ultimately my sense is this is something we should try to support though. I think the usefulness probably outweighs the potential for doing weird things. |
I like Lisp approach (in my opinion, the utmost language when it comes to meta-programming). Instead of defining a |
For something like debounce, a more aspect-like approach seems preferable. Say, if you could declaratively wrap a function body with some template code: class Example {
void doSomething() with debounce(Duration(seconds: 1)) {
print('doSomething');
}
void doSomethingElse(int value, {String named}) with debounce(Duration(seconds: 1)) {
print('doSomethingElse $value named: $named');
}
}
template debounce<R>(Duration duration) on R Function {
template final Stopwatch? sw;
template late R result;
if (sw != null && sw.elapsed < duration) {
return result;
} else {
(sw ??= Stopwatch()..start()).reset();
return result = super;
}
} This defines a "function template" (really, a kind of function mixin) which can be applied to other functions. (Maybe we just need AspectD for Dart.) |
But an important part of function composition is also the ability to inject parameters and ask for more parameters. For example, a good candidate is functional stateless-widgets, to add a @statelessWidget
Widget example(BuildContext context, {required String name}) {
return Text(name);
} and the resulting prototype after composition would be: Widget Function({Key? key, required String name}) where the final code would be: class _Example extends StatelessWidget {
Example({Key? key, required String name}): super(key: key);
final String name;
@override
Widget build(BuildContext) => originalExampleFunction(context, name: name);
}
Widget example({Key? key, required String name}) {
return _Example(key: key, name: name);
} |
I definitely agree we don't want to allow for changing the signature of the function from what was written. I don't think that is prohibitive though as long as you are allowed to generate a new function/method next to the existing one with the signature you want. The original function might be private in that case. |
That's what functional_widget does, but the consequence is that the developer experience is pretty bad. A major issue is that it breaks the "go to definition" functionality because instead of being redirected to their function, users are redirected to the generated code It also causes a lot of confusion around naming. Because it's common to want to have control on whether the generated class/function is public or private, but the original function to always be private. By modifying the prototype instead, this gives more control to users over the name of the generated functions. |
Allowing the signature to be modified has a lot of disadvantages as well. I think its probably worse to see a function which is written to have a totally different signature than it actually has, than to be navigated to a generated function (which you can then follow through to the real one). You can potentially blackbox those functions in the debugger as well so it skips right to the real one if you are stepping through. |
I suppose this will allow generating |
Yes. |
@tatumizer This issue is just for the general problem of static metaprogramming. What you describe would be one possible solution to it, although we are trying to avoid exposing a full AST api because that can make it hard to evolve the language in the future. See https://github.com/dart-lang/language/blob/master/working/static%20metaprogramming/intro.md for an intro into the general design direction we are thinking of here which I think is not necessarily so far off from what you describe (although the mechanics are different). |
Great intro & docs. Hopefully we'll stay (far far) away from annotations to develop/work with static meta programming?! |
The main reason we use this as an example is its well understood by many people, and it is also actually particularly demanding in terms of features to actually implement due to the public api itself needing to be generated :).
Can you elaborate? Default values for parameters are getting some important upgrades in null safe dart (at least the major loophole of being able to override them accidentally by passing |
I believe the issue is that we cannot easily differentiate between freezed supports this, but only because it relies on factory constructors and interface to hide the internals of |
Right, this is what I was describing which null safety actually does fix at least partially. You can make the parameter non-nullable (with a default), and then null can no longer be passed at all. Wrapping functions are required to copy the default value, basically it forces you to explicitly handle this does cause some extra boilerplate but is safe. For nullable parameters you still can't differentiate (at least in the function wrapping case, if they don't provide a default as well) |
Metaprogramming is a broad topic. How to rationalize? We should start with what gives the best bang for buck (based on use cases). Draft topics for meta programming 'output' code:
Also on output code:
Would be great if this could work without saving the file, a IDE-like syntax (hidden) code running continuously if syntax is valid. I refuse to use build_runner's |
Metaprograming opens doors to many nice features Other language that does a great job at implementing macros is Haxe you can use Haxe language to define macros I guess there are many challenges to implement this. |
can we extend classes with analyzer plugin? |
I'm not sure if I like the idea having this added to Dart because the beauty of Dart is its simplicity. The fact that it isn't as concise as other languages it in reality an advantage because it makes Dart code really easy to read and to reason about. |
I agree with this. |
@escamoteur Writing less code does not make it more complicated necessarily. It can, I agree, if someone does not fully understand the new syntax. But the trade-off is obvious: time & the number of lines saved vs the need for someone to learn a few capabilities. Generated code is normal simple code. I just suggested real-time code generation instead of running the builder every time or watching it to save. That way you get real time goto. But if you are using notepad then of course you need to run a process. |
Just to be 100% clear, we are intensely focused on these exact questions. We will not ship something which does not integrate well with all of our tools and workflows. You should be able to read code and understand it, go to definition, step through the code in the debugger, get good error messages, get clear and comprehensible stack traces, etc. |
In my honest opinion: things must be obvious, not magical.
^ this |
But there is nothing beautiful about writing data classes or running complicated and and slow code-generation tools. I'm hoping this can lead to more simplicity not less. Vast mounds of code will be removed from our visible classes. StatefulWidget can maybe just go away? (compiler can run the split macro before it builds?). Things can be auto-disposed. Seems like this could hit a lot of pain points, not just data classes and serialization.. |
Since dart currently offers code generation for similar jobs-to-be-done, I'd suggest evaluating potential concerns with that consideration:
On the other hand, besides being an upgrade from codegen for developers, metaprogramming could provide healthier means for language evolution beyond getting data classes done. Quoting Bryan Cantrill:
PS @jakemac53 the |
this would be fantastic if it allowed, the longed-for serialization for JSON natively without the need for manual code generation or reflection in time of execution Today practically all applications depend on serialization for JSON, a modern language like dart should already have a form of native serialization in the language, being obliged to use manual codegen or typing serialization manually is something very unpleasant |
My approach on a macro mechanism. Basically tagging a certain scope with a macro annotation, that refers to one or multiple classes to 1:1 replace the code virtually... like a projection. It's very easy to understand and QOL can be extended by providing utility classes. #ToStringMaker() // '#' indicates macro and will rewrite all code in next scope
class Person {
String name;
int age;
}
// [REWRITTEN CODE] => displayed readonly in IDE
// class Person {
// String name;
// int age;
//
// toString() => 'Person(vorname:$name, age:$age)'
// }
class ToStringMaker extends Macro {
// fields and constructor can optionally obtain parameters
@override
String generate(String code, MacroContext context) { // MacroContext provides access to other Dart files in project and other introspection features
var writer = DartClassWriter(code); // DartClassWriter knows the structure of Dart code
writer.add('String toString() => \'${writer.className}(${writer.fields.map(field => '${field.name}:\${field.name}').join(', ')})\'');
return writer.code; // substitute code for referenced scope
}
} |
Good to see that, despite all this, augmentations will be unaffected. Does this mean that - in the very far away future - a different avenue could be considered to give macro's a second try? |
You might as well include build runner and json_serializable in stdlib, then. Disappointing. |
I wouldn't bet on that. Otherwise I doubt the team would've cancelled macros. But we can have alternatives! |
Will |
In that case, can we put effort into making using build_runner easier to work with? most of the time I have no idea how to even do anything! |
From the article:
I don't understand that. If reflection is supported only during build runner run, this doesn't affect any further optimizations at all. |
I think one of the bigger potential improvements that could happen to the build system side of things would be from a documentation and tutorial point of view. What already exists today is incredibly powerful and has some really nice features but getting started is very complicated and not a clear path for many. |
Augmentations and a faster build_runner are more than enough. |
I've mentioned it in many other places, but I think another critical feature for better codegen is the changing "go-to-definition" to avoid having to step through the generated code. Cf: |
It would be great to avoid out-of-sync build_runner generated files on disk and eliminate the need to manually run build_runner. |
No. I wish this would be true. Some examples include, but are not limited to:
As you can see most of these problems are intertwined with other aspects of the language: analysis, packages, hot reload, dependencies, mono repo scripts, etc. |
My feeling is that multi-staged augmentations will only aggravate and perpetuate the problem. The alternative is to spend another 2 years in a futile pursuit of composability, with the same result. |
@mit-mit https://learn.microsoft.com/en-us/dotnet/csharp/whats-new/tutorials/static-virtual-interface-members |
Hi folks - We're all of course quite disappointed about this. @jakemac53 and company did a lot of amazing work to try to make this happen. Making the call to cut our losses and move on was terribly difficult. I do very much believe it was the right call though, and I'm very excited about the opportunities this opens up. I do want to be very clear - we have no plans to pick this up again. That's not to say that we never will. I still love a lot of the ideas we explored, and I do think that some form of macro system (even if more limited) would be a great addition to Dart. But the decision here is to move the effort onto more focused language features to solve the core user problems, and that simply doesn't leave room on our roadmap to pick this work up in the foreseeable future. I do hope that with augmentations and some work on the build infrastructure we can make codegen in Dart substantially better. I think we learned a lot from the macros effort that can potentially be applied here. I don't think this will be enough in and of itself though, and we will be taking a fresh look at what features we should add to the language to make working with data and serialization great. Many of the ideas mentioned in this thread are on the table, but this discussion is still very open ended. We also of course will be continuing to ship features to keep making Dart more usable, fresh and modern. Static access shorthands are in the implementation pipeline now and we're actively working on getting a few more things spec'ed out and ready for the implementation teams this year. I'm very much looking forward to the seeing what we can build out in the next few years. Thanks for all of the interest and discussion on the issue tracker, and thanks for being part of the Dart community! |
Thanks @lucavenir ... I really feel all those points, having worked on macros for a year. I'd like to reassure that we are not giving up on solving those problems--rather we are now going to tackle them piece by piece instead of, as you say, all in one fell swoop :) For my part, I'll be starting on that by working on the performance question here. |
I’m sad that this is now discontinued and don’t get me wrong,
you’re talking about? I work on medium-sized projects on a medium machine and my build times are about 3-5 minutes. Again, don’t get me wrong, I’m just genuinely interested since I haven’t seen anyone say anything specific. |
I consider 3-5 minutes to be gargantuan for anything that is part of your dev workflow :) It's supposed to be an interactive experience, not "grab a cup of coffee" :) |
@TheHudek For my team after using @davidmorgan I think
So instead of a big Macros feature, we would have a Macros Goal, not a feature |
This varies a lot depending on the machine. In my old laptop, build times that used to take 5 minutes are now taking 1 minute after switched to a M3 Pro. However, I always think that people overexaggerate the cost of I'm more worried about the stability of the tool than the performance. Again, performance improvements are always welcome, but most of my frustration on using |
In my opinion, by adding native data classes (possibly with primary constructors) and improving serialization, which are pain points for developers, will greatly reduce the amount of work required by build_runner and thus the execution time. Combined with your suggested improvements and augmentations (which is btw is a very valuable result of the static metaprogramming topic) will greatly improve dart code generation in general, and macros won't be missed so much. |
Indeed that can work pretty well. When it becomes a problem is if your data model depends on your app code--then it wants to run whenever there is a change. However,
Improving stability sounds good to me, filed dart-lang/build#3801 to track. I do want to look at performance first, but there's no harm in starting to collect examples of stability problems. Thanks! |
Very sad. Is this dart`s death? |
Wait... that's acceptable? Even on a first start? As mentioned by others, the problem is the development cycle. We're speaking about one minute of build times between saves, plus analysis times. And this is happening in a monorepo (i.e. split code), with "optimizations" such as This, added to the fact that most times @davidmorgan thank you. Addressing runner times is a good starter but, as shown above, that's just the tip of the iceberg, believe me. |
I think we are in agreement :) |
That's pretty much how we're thinking of it, yes. Not macros as a feature but all the different things needed to address the main use cases that macros were intended to address. Augmentations is still proceeding as planned. |
Can we ship a lint that suggests not to put logic onto these files? e.g. @freezed
class DataClass ... {}
extension ApiDataClassExt on AnotherApiDataClassOnAnotherFile {
// adapter
DataClass toEntity() => ...
} This is very, very handy. But because of the runner, I can't simply do this at scale. |
@lucavenir |
Cool, but that should be part of the whole ecosystem. Not just freezed. Remember: this issue addresses every static metaprogramming idea we've had. Examples include Riverpod, GoRouter, etc. |
No, we won't ask people to keep logic out of their source files to make codegen fast. We will make it fast for that case :) That said, it is a good idea to structure your code in a modular way. So for example if you think about how you want your data classes to work, and decide that they shouldn't depend on your UI code, then make that a clear separation: your code will be better and it will probably help the tools work faster. But we don't want you to have to make your code worse to help the tools. That's a problem with the tools. |
One of the issues with the current code generation approach is that the client developer needs to manually add part 'file.g.dart'; to the original code. It would be interesting if this wasn’t mandatory while still providing a way for the developer to see the included part directives. I’ve created an issue for this: #4241 |
Metaprogramming refers to code that operates on other code as if it were data. It can take code in as parameters, reflect over it, inspect it, create it, modify it, and return it. Static metaprogramming means doing that work at compile-time, and typically modifying or adding to the program based on that work.
Today it is possible to do static metaprogramming completely outside of the language - using packages such as build_runner to generate code and using the analyzer apis for introspection. These separate tools however are not well integrated into the compilers or tools, and it adds a lot of complexity where this is done. It also tends to be slower than an integrated solution because it can't share any work with the compiler.
Sample Use Case - Data Classes
The most requested open language issue is to add data classes. A data class is essentially a regular Dart class that comes with an automatically provided constructor and implementations of
==
,hashCode
, andcopyWith()
(calledcopy()
in Kotlin) methods based on the fields the user declares in the class.The reason this is a language feature request is because there’s no way for a Dart library or framework to add data classes as a reusable mechanism. Again, this is because there isn’t any easily available abstraction that lets a Dart user express “given this set of fields, add these methods to the class”. The
copyWith()
method is particularly challenging because it’s not just the bodyof that method that depends on the surrounding class’s fields. The parameter list itself does too.
We could add data classes to the language, but that only satisfies users who want a nice syntax for that specific set of policies. What happens when users instead want a nice notation for classes that are deeply immutable, dependency-injected, observable, or differentiable? Sufficiently powerful static metaprogramming could let users define these policies in reusable abstractions and keep the slower-moving Dart language out of the fast-moving methodology business.
Design
See this intro doc for the general design direction we are exploring right now.
Update January 2025
We have an unfortunate update on macros/metaprogramming. We have invested significant time and resources to prototype macros over the past couple years. Unfortunately, each time we solved a major technical hurdle, we saw new ones pop up. At this point, we are not seeing macros converging anytime soon toward a feature we are comfortable shipping, with the quality and developer-time performance we want.
After considering the opportunity cost — in particular, the features we could be shipping to the community instead — we’ve made the difficult decision to stop our work on macros.
For additional details, please see the blog post:
https://medium.com/dartlang/an-update-on-dart-macros-data-serialization-06d3037d4f12
The text was updated successfully, but these errors were encountered: