This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
Json benchmarks #52
Merged
Json benchmarks #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorgan
force-pushed
the
json-benchmarks
branch
2 times, most recently
from
5286f15 to
b8598c0
Compare
davidmorgan
force-pushed
the
json-benchmarks
branch
from
b8598c0 to
207f2a9
Compare
davidmorgan
force-pushed
the
json-benchmarks
branch
from
207f2a9 to
182b975
Compare
jakemac53
approved these changes
Aug 29, 2024
| isField: (intKey & 8) == 8, | ||
| isMethod: (intKey & 16) == 16, | ||
| isStatic: (intKey & 32) == 32)); | ||
| members['a'] = _makeMember('a'); |
There was a problem hiding this comment.
nit: should we create unique names, so that we actually encode more strings in the object and not just a ton of pointers? Just in case that matters, because in practice most members wont have the same names.
There was a problem hiding this comment.
Good point, done, this also addresses "member names won't be known in advance".
| import 'serialization_benchmark.dart'; | ||
|
|
||
| /// Benchmark accumulating data into a [JsonBuffer] via [LazyMap]. | ||
| class BufferMapsBufferWireBenchmark extends SerializationBenchmark { |
There was a problem hiding this comment.
nit: include LazyMap in the name?
|
Thanks! Output after changes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the benchmarks I was using while writing
JsonBufferBuilder.The output is not particularly stable, as you can see from the variation over three runs, full output below. But it's enough for approximate work :)