Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevCompiler] Optional named parameter ignored? #34088

Closed
cedx opened this issue Aug 7, 2018 · 1 comment
Closed

[DevCompiler] Optional named parameter ignored? #34088

cedx opened this issue Aug 7, 2018 · 1 comment
Labels
closed-duplicate Closed in favor of an existing report

Comments

@cedx
Copy link

cedx commented Aug 7, 2018

  • Dart SDK Version: 2.0.0 (Fri Aug 3 10:53:23 2018 +0200) on "windows_x64"
  • build_runner: 0.10.0, build_test: 0.10.3, build_web_compilers: 0.4.1, test: 1.3.0
  • OS: Windows 10 (64-bit)
  • Test browser: Chrome 68
  • Any other packages or constraints: json_annotation: 1.0.0, json_serializable: 1.0.1.

I have a project (https://github.com/cedx/lcov.dart) whose tests give different results when run by dart2js and the dev compiler:
dart-lang/build#1724

A FunctionData#toString({bool asDefinition = false}) method is called two times: with asDefinition = true and asDefinition = false (see: https://github.com/cedx/lcov.dart/blob/master/lib/src/function.dart#L33).

When the tests use the dev compiler, it looks like the optional named parameter asDefinition is ignored: its value always seems to be false.

@matanlurey matanlurey added the closed-duplicate Closed in favor of an existing report label Aug 7, 2018
@matanlurey
Copy link
Contributor

Duplicate of #33876

I believe it is fixed at HEAD but not in a release yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report
Projects
None yet
Development

No branches or pull requests

2 participants