Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow generic function types as type arguments #44930

Closed
a-siva opened this issue Feb 9, 2021 · 2 comments
Closed

Allow generic function types as type arguments #44930

a-siva opened this issue Feb 9, 2021 · 2 comments
Assignees
@crelier
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug
Milestone
March Beta Release

Comments

@a-siva
Copy link
Contributor

a-siva commented Feb 9, 2021

Allow generic function types as type arguments per dart-lang/language#496 in the VM
@a-siva a-siva added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug labels Feb 9, 2021
@a-siva a-siva added this to the March Beta Release milestone Feb 9, 2021
@a-siva a-siva mentioned this issue Feb 9, 2021
Closed
@a-siva
Copy link
Contributor Author

a-siva commented Mar 13, 2021

@crelier I presume you are still waiting for the CFE implementation to be completed before you can close this

@crelier
Copy link
Contributor

crelier commented Mar 16, 2021

Now that the CFE has provided an implementation behind a flag, I am able to test and I found 2 issues in the VM.
The first one relates to a wrong usage of the trail to avoid infinite recursion. It is easy to fix.
The second one is more complicated and relates to indices assigned by CFE in kernel files to reference declared type parameters. The VM and CFE are not agreeing on this assignment. Since this is not my code, I am still investigating to figure out who is correct and how to fix it. I suspect the issue is on the VM side. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crelier crelier

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
March Beta Release
Development

No branches or pull requests
2 participants
@crelier @a-siva